New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow empty arrays as values in grammar #407

Merged
merged 1 commit into from May 30, 2013

Conversation

Projects
None yet
2 participants
@piavlo
Contributor

piavlo commented Mar 16, 2013

Allow following config not to fail with parse error

filter {
  grok {
    tags                => [ "apache-accesslog" ]
    patterns_dir        => [ "/opt/logstash/patterns" ]
    match               => [ "clientip", "%{IP}" ]
    break_on_match      => true
    named_captures_only => true
    tag_on_failure      => [ ]
  }
}
@piavlo

This comment has been minimized.

Show comment
Hide comment
@piavlo

piavlo Apr 17, 2013

Contributor

@jordansissel - nagging since #405 was merged and this one is kind of related - as example in case we do not want to add any tags on parse failure.
And in general there is probably nothing wrong if grammar accepts empty arrays/hashes as possible values?

Contributor

piavlo commented Apr 17, 2013

@jordansissel - nagging since #405 was merged and this one is kind of related - as example in case we do not want to add any tags on parse failure.
And in general there is probably nothing wrong if grammar accepts empty arrays/hashes as possible values?

jordansissel added a commit that referenced this pull request May 30, 2013

Merge pull request #407 from piavlo/feature/grammar-allow-empty-array…
…-values

Allow empty arrays as values in grammar

@jordansissel jordansissel merged commit 4b64bcd into elastic:master May 30, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment