Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign upAllow empty arrays as values in grammar #407
Conversation
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment
Hide comment
piavlo
Apr 17, 2013
Contributor
@jordansissel - nagging since #405 was merged and this one is kind of related - as example in case we do not want to add any tags on parse failure.
And in general there is probably nothing wrong if grammar accepts empty arrays/hashes as possible values?
|
@jordansissel - nagging since #405 was merged and this one is kind of related - as example in case we do not want to add any tags on parse failure. |
added a commit
that referenced
this pull request
May 30, 2013
jordansissel
merged commit 4b64bcd
into
elastic:master
May 30, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
piavlo commentedMar 16, 2013
Allow following config not to fail with parse error
filter { grok { tags => [ "apache-accesslog" ] patterns_dir => [ "/opt/logstash/patterns" ] match => [ "clientip", "%{IP}" ] break_on_match => true named_captures_only => true tag_on_failure => [ ] } }