Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: add labels metadata #47

Merged
merged 1 commit into from Jul 1, 2020
Merged

Conversation

v1v
Copy link
Member

@v1v v1v commented Jul 1, 2020

Added some labels to easily identify what's the agent version that the opbeans is consuming, in addition to some labels that are generated for some other Elastic docker images.

Tests

IMAGE=docker.elastic.co/observability-ci/opbeans-python:63c87118dd931fdcf93bc7a6a26fb36b69546782
$ docker pull ${IMAGE}
$ docker inspect ${IMAGE} | jq -r '.[0].Config.Labels'
{
  "org.label-schema.license": "MIT",
  "org.label-schema.name": "opbeans-python",
  "org.label-schema.schema-version": "1.0",
  "org.label-schema.url": "https://hub.docker.com/r/opbeans/opbeans-python",
  "org.label-schema.vcs-url": "https://github.com/elastic/opbeans-python",
  "org.label-schema.vendor": "Elastic",
  "org.label-schema.version": "5.7.0"
}

@v1v v1v self-assigned this Jul 1, 2020
@v1v v1v added the automation label Jul 1, 2020
Copy link
Contributor

@beniwohli beniwohli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

(oops, missed that this is still a draft, sorry about that)

org.label-schema.schema-version="1.0" \
org.label-schema.vendor="Elastic" \
org.label-schema.name="opbeans-python" \
org.label-schema.version="5.7.0" \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We just released 5.8.0 yesterday, so would probably make sense to reflect that here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be bumped automatically, I'll review the process and bump it in another PR with the agent dependency, does it sound good?

@apmmachine
Copy link
Contributor

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #47 opened]

  • Start Time: 2020-07-01T11:57:21.009+0000

  • Duration: 9 min 54 sec

Test stats 🧪

Test Results
Failed 0
Passed 5
Skipped 0
Total 5

@v1v v1v marked this pull request as ready for review July 1, 2020 12:31
@v1v v1v requested a review from a team July 1, 2020 12:31
@v1v v1v merged commit e5cc68c into elastic:master Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants