From 47eaeaf0165771348fb234bb3545b2ede775540e Mon Sep 17 00:00:00 2001 From: Vishal Raj Date: Tue, 22 Oct 2024 17:33:44 +0100 Subject: [PATCH] [enrichments]Use representative count for success count attr --- enrichments/trace/internal/elastic/span.go | 2 +- enrichments/trace/internal/elastic/span_test.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/enrichments/trace/internal/elastic/span.go b/enrichments/trace/internal/elastic/span.go index 459a574..ea3cb71 100644 --- a/enrichments/trace/internal/elastic/span.go +++ b/enrichments/trace/internal/elastic/span.go @@ -322,7 +322,7 @@ func (s *spanEnrichmentContext) setTxnResult(span ptrace.Span) { func (s *spanEnrichmentContext) setEventOutcome(span ptrace.Span) { // default to success outcome outcome := "success" - successCount := 1 + successCount := getRepresentativeCount(span.TraceState().AsRaw()) switch { case s.spanStatusCode == ptrace.StatusCodeError: outcome = "failure" diff --git a/enrichments/trace/internal/elastic/span_test.go b/enrichments/trace/internal/elastic/span_test.go index 9febadf..714a1bc 100644 --- a/enrichments/trace/internal/elastic/span_test.go +++ b/enrichments/trace/internal/elastic/span_test.go @@ -96,7 +96,7 @@ func TestElasticTransactionEnrich(t *testing.T) { AttributeTransactionRepresentativeCount: float64(256), AttributeTransactionDurationUs: int64(0), AttributeEventOutcome: "success", - AttributeSuccessCount: int64(1), + AttributeSuccessCount: int64(256), AttributeTransactionResult: "Success", AttributeTransactionType: "unknown", },