Add rpc.service for the destination.service.resource calculation #160
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@AlexanderWert pointed out that some services in the OTel demo send GRPC spans with very few SemConv attributes. Here is an example of such a span from the
recommendationpython service:Although according to SemConv RPC spans have required attribute
server.address- it's not set by this python service. None of the other fields we use fordestination.service.resourceare set, but we haverpc.service.The problem with this is that without
destination.service.resource, the service map won't show this dependency.@AlexanderWert suggested to then just use this field as a fallback and set that as
destination.service.resource, which I think makes sense, because this field is needed for service map andrpc.servicestill identifies the target service.Service map prior to this PR:

Service map with this PR:

Note that the real service is still not resolved on the map; I'm not sure it's related to this thing... I see that all the time, also when the call happens via HTTP. So far my guess is that it's not relevant, but if someone knows more, let me know.