Skip to content

Conversation

@narcher7
Copy link
Contributor

@narcher7 narcher7 commented Nov 3, 2020

No description provided.

@narcher7 narcher7 requested a review from jmikell821 November 3, 2020 18:25
@narcher7 narcher7 self-assigned this Nov 3, 2020
@jmikell821
Copy link
Contributor

@Donnater in general, we should try to start each bullet with an action point (e.g,Adds, Fixes, Allows, etc). Some of them have it; others do not. We'll need to tweak the title that generates from the script majority of the time so it's user-friendly.

narcher7 and others added 3 commits November 9, 2020 15:16
Co-authored-by: Janeen Mikell-Straughn <57149392+jmikell821@users.noreply.github.com>
Co-authored-by: Janeen Mikell-Straughn <57149392+jmikell821@users.noreply.github.com>
@narcher7 narcher7 requested a review from jmikell821 November 9, 2020 21:20
Comment on lines +31 to +39
*Signals template updated for rollover indices*

The `create_index_route` now checks if the template needs to be upgraded
before creating the index. If the index already exists and the template was upgraded,
the index rolls over so that the write index has the upgraded mapping.
This breaks the old mappings that have `risk_score mapped` as a keyword.
In the new mapping, `signal.rule.risk_score` is a float. After rolling over,
there is a conflict between the old and new `signal.rule.risk_score` for some
features, such as aggregations.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to call out the need to add the view_index_metadata permission here, as that's the change users will need to make for Event Correlation rules to function upon upgrade?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a note here and on the detections requirement page

@narcher7
Copy link
Contributor Author

Going to go ahead and merge these. Let me know if I need to add anything tomorrow morning.

@narcher7 narcher7 merged commit 3fbbdc6 into master Nov 11, 2020
@narcher7 narcher7 deleted the issue#269-7-10-release-notes branch November 11, 2020 03:14
narcher7 added a commit to narcher7/security-docs that referenced this pull request Nov 11, 2020
* Add security release notes

* Add action verbs to each item

* Group feature-specific line items to the bottom

* Remove mention of resolver

* Add breaking changes section

* Update docs/release-notes.asciidoc

Co-authored-by: Janeen Mikell-Straughn <57149392+jmikell821@users.noreply.github.com>

* Incorporate Janeen's feedback

* Update docs/release-notes.asciidoc

Co-authored-by: Janeen Mikell-Straughn <57149392+jmikell821@users.noreply.github.com>

* Add 7.10 known issue.

* slight grammar edit

* Add feedback

* Add note about view-index-metadata

Co-authored-by: Janeen Mikell-Straughn <57149392+jmikell821@users.noreply.github.com>
narcher7 added a commit to narcher7/security-docs that referenced this pull request Nov 11, 2020
* Add security release notes

* Add action verbs to each item

* Group feature-specific line items to the bottom

* Remove mention of resolver

* Add breaking changes section

* Update docs/release-notes.asciidoc

Co-authored-by: Janeen Mikell-Straughn <57149392+jmikell821@users.noreply.github.com>

* Incorporate Janeen's feedback

* Update docs/release-notes.asciidoc

Co-authored-by: Janeen Mikell-Straughn <57149392+jmikell821@users.noreply.github.com>

* Add 7.10 known issue.

* slight grammar edit

* Add feedback

* Add note about view-index-metadata

Co-authored-by: Janeen Mikell-Straughn <57149392+jmikell821@users.noreply.github.com>
narcher7 added a commit that referenced this pull request Nov 11, 2020
* Add security release notes

* Add action verbs to each item

* Group feature-specific line items to the bottom

* Remove mention of resolver

* Add breaking changes section

* Update docs/release-notes.asciidoc

Co-authored-by: Janeen Mikell-Straughn <57149392+jmikell821@users.noreply.github.com>

* Incorporate Janeen's feedback

* Update docs/release-notes.asciidoc

Co-authored-by: Janeen Mikell-Straughn <57149392+jmikell821@users.noreply.github.com>

* Add 7.10 known issue.

* slight grammar edit

* Add feedback

* Add note about view-index-metadata

Co-authored-by: Janeen Mikell-Straughn <57149392+jmikell821@users.noreply.github.com>

Co-authored-by: Janeen Mikell-Straughn <57149392+jmikell821@users.noreply.github.com>
narcher7 added a commit that referenced this pull request Nov 11, 2020
* Add security release notes

* Add action verbs to each item

* Group feature-specific line items to the bottom

* Remove mention of resolver

* Add breaking changes section

* Update docs/release-notes.asciidoc

Co-authored-by: Janeen Mikell-Straughn <57149392+jmikell821@users.noreply.github.com>

* Incorporate Janeen's feedback

* Update docs/release-notes.asciidoc

Co-authored-by: Janeen Mikell-Straughn <57149392+jmikell821@users.noreply.github.com>

* Add 7.10 known issue.

* slight grammar edit

* Add feedback

* Add note about view-index-metadata

Co-authored-by: Janeen Mikell-Straughn <57149392+jmikell821@users.noreply.github.com>

Co-authored-by: Janeen Mikell-Straughn <57149392+jmikell821@users.noreply.github.com>
joepeeples added a commit that referenced this pull request May 21, 2024
* Adds pricing table to billing dimensions page

* Update docs/billing.mdx

* Update docs/billing.mdx

Co-authored-by: Joe Peeples <joe.peeples@elastic.co>

* Corrects variable

---------

Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
joepeeples added a commit that referenced this pull request May 22, 2024
* Adds pricing table to billing dimensions page

* Update docs/billing.mdx

* Update docs/billing.mdx

Co-authored-by: Joe Peeples <joe.peeples@elastic.co>

* Corrects variable

---------

Co-authored-by: Joe Peeples <joe.peeples@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants