Skip to content

Conversation

@narcher7
Copy link
Contributor

@narcher7 narcher7 commented Nov 5, 2020

Fixes issue #261

@narcher7 narcher7 requested a review from michaelolo24 November 5, 2020 20:22
@narcher7
Copy link
Contributor Author

narcher7 commented Nov 5, 2020

Preview

Copy link
Contributor

@oatkiller oatkiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for these docs. They look awesome! I put a few comments in this review.

narcher7 and others added 2 commits November 9, 2020 09:26
Co-authored-by: Robert Austin <robert.austin@elastic.co>
@michaelolo24
Copy link

Thanks for making the changes!

Copy link
Contributor

@oatkiller oatkiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@narcher7 narcher7 merged commit da3a13d into master Nov 11, 2020
@narcher7 narcher7 deleted the issue-#261-analyze-events branch November 11, 2020 02:51
narcher7 added a commit to narcher7/security-docs that referenced this pull request Nov 11, 2020
* Visual event analyzer updates for 7.10

* Grammar edits

* Add note about analyzing events from timelines

* Rename header. Fix link. Merge Michael's feedback

* Fix small error

* Fix small formatting issues

* Update docs/detections/visual-event-analyzer.asciidoc

Co-authored-by: Robert Austin <robert.austin@elastic.co>

* Address additional feedback

* Remove additional information about event.category

Co-authored-by: Robert Austin <robert.austin@elastic.co>
narcher7 added a commit to narcher7/security-docs that referenced this pull request Nov 11, 2020
* Visual event analyzer updates for 7.10

* Grammar edits

* Add note about analyzing events from timelines

* Rename header. Fix link. Merge Michael's feedback

* Fix small error

* Fix small formatting issues

* Update docs/detections/visual-event-analyzer.asciidoc

Co-authored-by: Robert Austin <robert.austin@elastic.co>

* Address additional feedback

* Remove additional information about event.category

Co-authored-by: Robert Austin <robert.austin@elastic.co>
narcher7 added a commit that referenced this pull request Nov 11, 2020
* Visual event analyzer updates for 7.10

* Grammar edits

* Add note about analyzing events from timelines

* Rename header. Fix link. Merge Michael's feedback

* Fix small error

* Fix small formatting issues

* Update docs/detections/visual-event-analyzer.asciidoc

Co-authored-by: Robert Austin <robert.austin@elastic.co>

* Address additional feedback

* Remove additional information about event.category

Co-authored-by: Robert Austin <robert.austin@elastic.co>

Co-authored-by: Robert Austin <robert.austin@elastic.co>
narcher7 added a commit that referenced this pull request Nov 11, 2020
* Visual event analyzer updates for 7.10

* Grammar edits

* Add note about analyzing events from timelines

* Rename header. Fix link. Merge Michael's feedback

* Fix small error

* Fix small formatting issues

* Update docs/detections/visual-event-analyzer.asciidoc

Co-authored-by: Robert Austin <robert.austin@elastic.co>

* Address additional feedback

* Remove additional information about event.category

Co-authored-by: Robert Austin <robert.austin@elastic.co>

Co-authored-by: Robert Austin <robert.austin@elastic.co>
joepeeples pushed a commit that referenced this pull request May 21, 2024
joepeeples pushed a commit that referenced this pull request May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants