Skip to content

Conversation

@joepeeples
Copy link
Contributor

@joepeeples joepeeples commented Sep 20, 2024

Contributes to https://github.com/elastic/security-docs-internal/issues/11: post-release cleanup to remove the conditional DocIf syntax and alternate content.

Important

Do not merge until the custom user roles feature has been released to serverless production.

Previews

  • Click the link in the comment below, then in the Security card click View serverless docs.
  • Navigate to these pages, and confirm they display the correct information for custom roles in serverless:
    • Elastic Security requirements
    • Elastic Defend feature privileges
    • Configure network map data
    • Detections requirements
    • Entity risk scoring requirements
    • Cases requirements

@joepeeples joepeeples added Docset: Serverless Issues for Serverless Security ci:doc-build labels Sep 20, 2024
@joepeeples joepeeples self-assigned this Sep 20, 2024
@github-actions
Copy link

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@mergify

This comment was marked as resolved.

@elasticdocs
Copy link

elasticdocs commented Sep 20, 2024

🚀 Built elastic-dot-co-docs-preview-docs successfully!

Issues? Visit #next-docs in Slack

@joepeeples joepeeples marked this pull request as ready for review October 23, 2024 14:41
@joepeeples joepeeples requested a review from a team as a code owner October 23, 2024 14:41
@joepeeples
Copy link
Contributor Author

Custom roles feature has been released, and the respective feature flag enabled (https://github.com/elastic/docs-site/pull/41 merged). We can now remove the conditionals to clean up our code.

Copy link
Contributor

@nastasha-solomon nastasha-solomon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@joepeeples joepeeples merged commit 360e4c7 into main Oct 24, 2024
4 checks passed
@joepeeples joepeeples deleted the 11-custom-roles-remove-conditions branch October 24, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-skip Docset: Serverless Issues for Serverless Security

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants