Skip to content

[Request][8.16] Update nav references for all "Detection and alerts" topics #5979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Nov 8, 2024
Merged

[Request][8.16] Update nav references for all "Detection and alerts" topics #5979

merged 14 commits into from
Nov 8, 2024

Conversation

@nastasha-solomon
Copy link
Contributor

@nastasha-solomon nastasha-solomon commented Oct 24, 2024 •
edited
Loading

@nastasha-solomon nastasha-solomon added Feature: New Navigation Issues/PRs that affect navigation in Security and/or Kibana Priority: High Issues that are time-sensitive and/or are of high customer importance Effort: Large Issues that require significant planning, research, writing, and testing Docset: ESS Issues that apply to docs in the Stack release v8.16.0 v8.17.0 labels Oct 24, 2024
@nastasha-solomon nastasha-solomon self-assigned this Oct 24, 2024
@github-actions
Copy link

github-actions bot commented Oct 24, 2024

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@nastasha-solomon nastasha-solomon changed the title [Request][8.16] Update nav references for all "Detection and alerts" and "Investigation tools" topics [Request][8.16] Update nav references for all "Detection and alerts" topics Oct 25, 2024
@nastasha-solomon nastasha-solomon added Effort: Medium Issues that take moderate but not substantial time to complete and removed Effort: Large Issues that require significant planning, research, writing, and testing labels Oct 25, 2024
@nastasha-solomon nastasha-solomon marked this pull request as ready for review October 30, 2024 20:40
@nastasha-solomon nastasha-solomon requested a review from a team as a code owner October 30, 2024 20:40
@nastasha-solomon
Copy link
Contributor Author

nastasha-solomon commented Nov 4, 2024

Reverting this to draft to make a few more changes.

@nastasha-solomon nastasha-solomon marked this pull request as draft November 4, 2024 18:39
@nastasha-solomon nastasha-solomon marked this pull request as ready for review November 5, 2024 01:57
@mergify

This comment was marked as outdated.

Sign in to view
benironside
benironside approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@benironside benironside left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nastasha-solomon nastasha-solomon merged commit 2736ed0 into main Nov 8, 2024
3 checks passed
mergify bot pushed a commit that referenced this pull request Nov 8, 2024
@nastasha-solomon @mergify
[Request][8.16] Update nav references for all "Detection and alerts" …
ca78e26 
…topics (#5979)

* First draft

* Second draft

* Fix refs

* Addresses comments

* removes additional comment

* Changes menu to navigation

* re-adds menu after nav

* Removes main

* Revisiting instructions to rules page

* remove duplicate 'the'

---------

Co-authored-by: Colleen McGinnis <colleen.mcginnis@elastic.co>
(cherry picked from commit 2736ed0)

# Conflicts:
#	docs/serverless/alerts/alert-suppression.asciidoc
@mergify mergify bot mentioned this pull request Nov 8, 2024
Merged
mergify bot pushed a commit that referenced this pull request Nov 8, 2024
@nastasha-solomon @mergify
[Request][8.16] Update nav references for all "Detection and alerts" …
0bceaf4 
…topics (#5979)

* First draft

* Second draft

* Fix refs

* Addresses comments

* removes additional comment

* Changes menu to navigation

* re-adds menu after nav

* Removes main

* Revisiting instructions to rules page

* remove duplicate 'the'

---------

Co-authored-by: Colleen McGinnis <colleen.mcginnis@elastic.co>
(cherry picked from commit 2736ed0)

# Conflicts:
#	docs/serverless/alerts/alert-suppression.asciidoc
@mergify mergify bot mentioned this pull request Nov 8, 2024
Merged
nastasha-solomon added a commit that referenced this pull request Nov 8, 2024
@mergify @nastasha-solomon @github-actions
[8.16] [Request][8.16] Update nav references for all "Detection and a…
bb73fbf 
…lerts" topics (backport #5979) (#6082)

* [Request][8.16] Update nav references for all "Detection and alerts" topics (#5979)

* First draft

* Second draft

* Fix refs

* Addresses comments

* removes additional comment

* Changes menu to navigation

* re-adds menu after nav

* Removes main

* Revisiting instructions to rules page

* remove duplicate 'the'

---------

Co-authored-by: Colleen McGinnis <colleen.mcginnis@elastic.co>
(cherry picked from commit 2736ed0)

# Conflicts:
#	docs/serverless/alerts/alert-suppression.asciidoc

* Delete docs/serverless directory and its contents

---------

Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
nastasha-solomon added a commit that referenced this pull request Nov 8, 2024
@mergify @nastasha-solomon @github-actions
[8.x] [Request][8.16] Update nav references for all "Detection and al…
8e921a3 
…erts" topics (backport #5979) (#6081)

* [Request][8.16] Update nav references for all "Detection and alerts" topics (#5979)

* First draft

* Second draft

* Fix refs

* Addresses comments

* removes additional comment

* Changes menu to navigation

* re-adds menu after nav

* Removes main

* Revisiting instructions to rules page

* remove duplicate 'the'

---------

Co-authored-by: Colleen McGinnis <colleen.mcginnis@elastic.co>
(cherry picked from commit 2736ed0)

# Conflicts:
#	docs/serverless/alerts/alert-suppression.asciidoc

* Delete docs/serverless directory and its contents

---------

Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benironside benironside benironside approved these changes

Assignees

@nastasha-solomon nastasha-solomon

Labels

Docset: ESS Issues that apply to docs in the Stack release Effort: Medium Issues that take moderate but not substantial time to complete Feature: New Navigation Issues/PRs that affect navigation in Security and/or Kibana Priority: High Issues that are time-sensitive and/or are of high customer importance v8.16.0 v8.17.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Request][8.16] Update nav references for all "Detection and alerts" and "Investigation tools" topics

4 participants

@nastasha-solomon @benironside @colleenmcginnis