Skip to content

Conversation

@jmikell821
Copy link
Contributor

Adds 8.17 to list of backports.

Adds `8.17` to list of backports.
@jmikell821 jmikell821 requested a review from lcawl November 21, 2024 17:33
@jmikell821 jmikell821 requested a review from a team as a code owner November 21, 2024 17:33
@github-actions
Copy link

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

Copy link
Contributor

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@nastasha-solomon nastasha-solomon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving this since @lcawl gave the thumbs up. But to be transparent, I don't fully understand why we're updating this file in the 8.x branch and how it'll affect PRs that are merged directly into 8.x instead of main.

@benironside benironside merged commit 6ae7850 into 8.x Nov 21, 2024
4 checks passed
@lcawl lcawl deleted the jmikell821-patch-1 branch November 21, 2024 19:53
@lcawl
Copy link
Contributor

lcawl commented Nov 21, 2024

But to be transparent, I don't fully understand why we're updating this file in the 8.x branch and how it'll affect PRs that are merged directly into 8.x instead of main.

Per https://github.com/sorenlouv/backport/blob/main/docs/config-file-options.md#project-config-backportrcjson that section of the file is just the "List of target branches the user can select interactively". Thus if someone has the 8.x branch checked out and runs the backport command, it'll now include v8.17 in the list of possible target branches.

@nastasha-solomon
Copy link
Contributor

nastasha-solomon commented Nov 21, 2024

Oh, nice. I didn't know that file existed and completely forgot about our internal backport tool (we've mainly worked with Mergify 😅). Thanks for sharing the docs, @lcawl. The updates @jmikell821 made make much more sense now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants