Skip to content

Conversation

@benironside
Copy link
Contributor

Fixes #6041 as part of #257

8.x release notes, as well as what's new, need to be removed from main in preparation for 9.0.

@benironside benironside self-assigned this Nov 26, 2024
@benironside benironside requested a review from a team as a code owner November 26, 2024 20:01
@github-actions
Copy link

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@mergify
Copy link
Contributor

mergify bot commented Nov 26, 2024

This pull request does not have a backport label. Could you fix it @benironside? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • v7.x is the label to automatically backport to the 7.x branch.
  • v7./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

Copy link
Contributor

@nastasha-solomon nastasha-solomon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this @benironside! The local preview looked good and didn't contain any leftover What's new files/pages or 8.x release notes. Approving early so it's ready to merge once the CI checks pass.

@@ -1,87 +1,5 @@
[[release-notes]]
[chapter]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@benironside you might need to remove this if you re-add the what's new page.

@benironside
Copy link
Contributor Author

run docs-build

Copy link
Contributor

@nastasha-solomon nastasha-solomon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, everything looks good @benironside! It's interesting that two chapter tags (namely the new one added here) don't affect the CI checks or TOC structure at all. I don't know enough about the book tags to suggest a change though so if it works, I don't want to mess with it anymore. Anywho, looks good to merge!

@benironside benironside merged commit e91fcff into main Dec 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove 8.x release notes from main

3 participants