-
Notifications
You must be signed in to change notification settings - Fork 206
Removes 8.x RNs and What's new from main #6246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
|
This pull request does not have a backport label. Could you fix it @benironside? 🙏
NOTE: |
nastasha-solomon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this @benironside! The local preview looked good and didn't contain any leftover What's new files/pages or 8.x release notes. Approving early so it's ready to merge once the CI checks pass.
| @@ -1,87 +1,5 @@ | |||
| [[release-notes]] | |||
| [chapter] | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@benironside you might need to remove this if you re-add the what's new page.
|
run docs-build |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, everything looks good @benironside! It's interesting that two chapter tags (namely the new one added here) don't affect the CI checks or TOC structure at all. I don't know enough about the book tags to suggest a change though so if it works, I don't want to mess with it anymore. Anywho, looks good to merge!
Fixes #6041 as part of #257
8.x release notes, as well as what's new, need to be removed from main in preparation for 9.0.