Skip to content

Conversation

@rseldner
Copy link
Contributor

@rseldner rseldner commented Jan 14, 2025

Small PR to explicitly state the fallback behavior on timestamp overrides.
It is currently implied with the mention of the Do not use @timestamp as a fallback timestamp field option

… overrides

Explicitly state the fallback behavior on timestamp overrides.
@github-actions
Copy link

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@rseldner rseldner added documentation Improvements or additions to documentation Team: Docs labels Jan 14, 2025
@mergify
Copy link
Contributor

mergify bot commented Jan 14, 2025

This pull request does not have a backport label. Could you fix it @rseldner? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • v7.x is the label to automatically backport to the 7.x branch.
  • v7./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

Copy link
Contributor

@nastasha-solomon nastasha-solomon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making this correction @rseldner! Let me know if my suggestions work and I can add them the docs.

@nastasha-solomon nastasha-solomon self-assigned this Jan 15, 2025
@nastasha-solomon nastasha-solomon added the bug Something isn't working label Jan 15, 2025
@nastasha-solomon nastasha-solomon marked this pull request as ready for review January 15, 2025 19:07
@nastasha-solomon nastasha-solomon requested a review from a team as a code owner January 15, 2025 19:07
@nastasha-solomon nastasha-solomon added Feature: Rules Team: Detection Engine Priority: Medium Issues that have relevance, but aren't urgent Effort: Small Issues that can be resolved quickly labels Jan 15, 2025
approksiu
approksiu previously approved these changes Jan 17, 2025
Copy link
Contributor

@approksiu approksiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Co-authored-by: Yara Tercero <yctercero@users.noreply.github.com>
nastasha-solomon and others added 2 commits January 21, 2025 13:25
@nastasha-solomon nastasha-solomon merged commit e9f0d81 into main Jan 21, 2025
3 checks passed
mergify bot pushed a commit that referenced this pull request Jan 21, 2025
…rides (#6425)

* Update rules-ui-create.asciidoc - Note fallback behavior in timestamp overrides

Explicitly state the fallback behavior on timestamp overrides.

* Serverless updates

* Update docs/detections/rules-ui-create.asciidoc

* Update docs/detections/rules-ui-create.asciidoc

* formatting fix

* Update docs/detections/rules-ui-create.asciidoc

Co-authored-by: Yara Tercero <yctercero@users.noreply.github.com>

* Update docs/serverless/rules/rules-ui-create.asciidoc

Co-authored-by: Yara Tercero <yctercero@users.noreply.github.com>

---------

Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com>
Co-authored-by: nastasha.solomon <nastasha.solomon@elastic.co>
Co-authored-by: Yara Tercero <yctercero@users.noreply.github.com>
(cherry picked from commit e9f0d81)

# Conflicts:
#	docs/serverless/rules/rules-ui-create.asciidoc
mergify bot pushed a commit that referenced this pull request Jan 21, 2025
…rides (#6425)

* Update rules-ui-create.asciidoc - Note fallback behavior in timestamp overrides

Explicitly state the fallback behavior on timestamp overrides.

* Serverless updates

* Update docs/detections/rules-ui-create.asciidoc

* Update docs/detections/rules-ui-create.asciidoc

* formatting fix

* Update docs/detections/rules-ui-create.asciidoc

Co-authored-by: Yara Tercero <yctercero@users.noreply.github.com>

* Update docs/serverless/rules/rules-ui-create.asciidoc

Co-authored-by: Yara Tercero <yctercero@users.noreply.github.com>

---------

Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com>
Co-authored-by: nastasha.solomon <nastasha.solomon@elastic.co>
Co-authored-by: Yara Tercero <yctercero@users.noreply.github.com>
(cherry picked from commit e9f0d81)

# Conflicts:
#	docs/serverless/rules/rules-ui-create.asciidoc
mergify bot pushed a commit that referenced this pull request Jan 21, 2025
…rides (#6425)

* Update rules-ui-create.asciidoc - Note fallback behavior in timestamp overrides

Explicitly state the fallback behavior on timestamp overrides.

* Serverless updates

* Update docs/detections/rules-ui-create.asciidoc

* Update docs/detections/rules-ui-create.asciidoc

* formatting fix

* Update docs/detections/rules-ui-create.asciidoc

Co-authored-by: Yara Tercero <yctercero@users.noreply.github.com>

* Update docs/serverless/rules/rules-ui-create.asciidoc

Co-authored-by: Yara Tercero <yctercero@users.noreply.github.com>

---------

Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com>
Co-authored-by: nastasha.solomon <nastasha.solomon@elastic.co>
Co-authored-by: Yara Tercero <yctercero@users.noreply.github.com>
(cherry picked from commit e9f0d81)

# Conflicts:
#	docs/serverless/rules/rules-ui-create.asciidoc
@nastasha-solomon nastasha-solomon deleted the rseldner-patch-1 branch January 21, 2025 22:43
nastasha-solomon pushed a commit that referenced this pull request Jan 22, 2025
…mp overrides (backport #6425) (#6464)

* Update rules-ui-create.asciidoc - fallback behavior in timestamp overrides (#6425)

* Update rules-ui-create.asciidoc - Note fallback behavior in timestamp overrides

Explicitly state the fallback behavior on timestamp overrides.

* Serverless updates

* Update docs/detections/rules-ui-create.asciidoc

* Update docs/detections/rules-ui-create.asciidoc

* formatting fix

* Update docs/detections/rules-ui-create.asciidoc

Co-authored-by: Yara Tercero <yctercero@users.noreply.github.com>

* Update docs/serverless/rules/rules-ui-create.asciidoc

Co-authored-by: Yara Tercero <yctercero@users.noreply.github.com>

---------

Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com>
Co-authored-by: nastasha.solomon <nastasha.solomon@elastic.co>
Co-authored-by: Yara Tercero <yctercero@users.noreply.github.com>
(cherry picked from commit e9f0d81)

# Conflicts:
#	docs/serverless/rules/rules-ui-create.asciidoc

* Delete docs/serverless directory and its contents

---------

Co-authored-by: Roberto Seldner <rseldner@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
nastasha-solomon pushed a commit that referenced this pull request Jan 22, 2025
…mp overrides (backport #6425) (#6465)

* Update rules-ui-create.asciidoc - fallback behavior in timestamp overrides (#6425)

* Update rules-ui-create.asciidoc - Note fallback behavior in timestamp overrides

Explicitly state the fallback behavior on timestamp overrides.

* Serverless updates

* Update docs/detections/rules-ui-create.asciidoc

* Update docs/detections/rules-ui-create.asciidoc

* formatting fix

* Update docs/detections/rules-ui-create.asciidoc

Co-authored-by: Yara Tercero <yctercero@users.noreply.github.com>

* Update docs/serverless/rules/rules-ui-create.asciidoc

Co-authored-by: Yara Tercero <yctercero@users.noreply.github.com>

---------

Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com>
Co-authored-by: nastasha.solomon <nastasha.solomon@elastic.co>
Co-authored-by: Yara Tercero <yctercero@users.noreply.github.com>
(cherry picked from commit e9f0d81)

# Conflicts:
#	docs/serverless/rules/rules-ui-create.asciidoc

* Delete docs/serverless directory and its contents

---------

Co-authored-by: Roberto Seldner <rseldner@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
nastasha-solomon added a commit that referenced this pull request Jan 22, 2025
…p overrides (backport #6425) (#6463)

* Update rules-ui-create.asciidoc - fallback behavior in timestamp overrides (#6425)

* Update rules-ui-create.asciidoc - Note fallback behavior in timestamp overrides

Explicitly state the fallback behavior on timestamp overrides.

* Serverless updates

* Update docs/detections/rules-ui-create.asciidoc

* Update docs/detections/rules-ui-create.asciidoc

* formatting fix

* Update docs/detections/rules-ui-create.asciidoc

Co-authored-by: Yara Tercero <yctercero@users.noreply.github.com>

* Update docs/serverless/rules/rules-ui-create.asciidoc

Co-authored-by: Yara Tercero <yctercero@users.noreply.github.com>

---------

Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com>
Co-authored-by: nastasha.solomon <nastasha.solomon@elastic.co>
Co-authored-by: Yara Tercero <yctercero@users.noreply.github.com>
(cherry picked from commit e9f0d81)

# Conflicts:
#	docs/serverless/rules/rules-ui-create.asciidoc

* Delete docs/serverless directory and its contents

---------

Co-authored-by: Roberto Seldner <rseldner@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Nastasha Solomon <79124755+nastasha-solomon@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working documentation Improvements or additions to documentation Effort: Small Issues that can be resolved quickly Feature: Rules Priority: Medium Issues that have relevance, but aren't urgent Team: Detection Engine Team: Docs v8.16.0 v8.17.0 v8.18.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants