Add resource ec_snapshot_repository - #613
Merged
Merged
Conversation
Collaborator
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
pascal-hofmann
force-pushed
the
ec_snapshot_repository
branch
from
March 31, 2023 12:54
20bc1c2 to
f33684d
Compare
pascal-hofmann
marked this pull request as ready for review
March 31, 2023 12:59
Contributor
Author
tobio
reviewed
Apr 11, 2023
tobio
left a comment
tobio
left a comment
Member
There was a problem hiding this comment.
Code looks good, I think we should cover the generic repo type at the same time though.
pascal-hofmann
force-pushed
the
ec_snapshot_repository
branch
from
April 13, 2023 13:09
f33684d to
e11060a
Compare
pascal-hofmann
force-pushed
the
ec_snapshot_repository
branch
from
April 13, 2023 13:19
e11060a to
213988d
Compare
10 tasks
tobio
reviewed
Apr 17, 2023
pascal-hofmann
force-pushed
the
ec_snapshot_repository
branch
2 times, most recently
from
April 17, 2023 05:44
d80dd58 to
bc6521f
Compare
tobio
approved these changes
Apr 18, 2023
tobio
left a comment
tobio
left a comment
Member
There was a problem hiding this comment.
LGTM. Manually tested this against a GCS snapshot repo 🎉
Can we add an entry to .changelog here as the final thing please.
This updates elastic/cloud-sdk-go to v1.12.1 because of `snaprepoapi.S3Config.PathStyleAccess` which was added there.
pascal-hofmann
force-pushed
the
ec_snapshot_repository
branch
from
April 19, 2023 07:37
bc6521f to
9584cf2
Compare
Contributor
Author
|
@tobio I've added an entry to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds a new resource
ec_snapshot_repositoryfor usage with ECE.Related Issues
#608
Motivation and Context
There is currently no way to create cluster level snapshot repositories in ECE via terraform.
How Has This Been Tested?
Types of Changes
Readiness Checklist
→ I did not run acceptance tests, but there are no changes that effect any of the existing functionality.
→ I think the failing unit tests are related to Infinite ec_deployment.elasticsearch.config drift when using ec 0.6.0 and terraform 1.4.0 #599 and are not caused by the changes in this PR.