Skip to content

Conversation

@dimuon
Copy link
Contributor

@dimuon dimuon commented Nov 20, 2025

Closes #847

@dimuon dimuon requested a review from Copilot November 20, 2025 18:05
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for .bedrock and .gen-ai connector types to the Terraform provider, enabling users to configure AWS Bedrock and generic AI connectors through Terraform resources. The implementation includes config validation, default value handling, and provider-specific field filtering for the .gen-ai connector type.

Key changes:

  • Added connector configuration handlers for .bedrock and .gen-ai types with appropriate defaults and validation
  • Implemented provider-specific config handling for .gen-ai (OpenAI, Azure OpenAI, Other)
  • Added comprehensive test coverage for both connector types

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file
File Description
internal/clients/kibana_oapi/connector.go Implements config handlers with defaults and validation for .bedrock and .gen-ai connectors
internal/clients/kibana_oapi/connector_test.go Adds comprehensive unit tests covering various configuration scenarios and edge cases
examples/resources/elasticstack_kibana_action_connector/resource.tf Provides example configurations for bedrock, OpenAI, and Azure OpenAI connectors
docs/resources/kibana_action_connector.md Documents the new connector types with usage examples
CHANGELOG.md Records the feature addition in the unreleased section

@dimuon dimuon marked this pull request as ready for review November 21, 2025 15:30
@dimuon dimuon requested review from a team, nick-benoit and tobio November 21, 2025 15:30
@tobio tobio requested a review from Copilot November 23, 2025 10:19
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated no new comments.

Copy link
Member

@tobio tobio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dimuon dimuon merged commit ef7bf07 into elastic:main Nov 24, 2025
26 checks passed
@dimuon dimuon deleted the gen-ai-bedrock-connectors branch November 25, 2025 08:39
nick-benoit pushed a commit that referenced this pull request Nov 25, 2025
* Support .bedrock and .gen-ai connectors

* Update changelog

* Acceptance test for bedrock connector

* Makefile target for running acc tests against started docker images

* Acc tests for bedrock and genai connectors

* Change min supported version for genai connector
tobio added a commit that referenced this pull request Nov 27, 2025
…ata-view-resource

* origin/main: (32 commits)
  chore(deps): update kibana-openapi-spec digest to c99d51c (#1487)
  [Feature] Introduce elasticsearch alias resource with atomic write index management and nested attributes (#1343)
  Support setting solution for 8.16+ on Cloud (#1486)
  Refactor all Kibana connector acceptance tests to use ConfigDirectory pattern (#1484)
  Support .bedrock and .gen-ai connectors (#1467)
  Bump golang.org/x/crypto from 0.41.0 to 0.45.0 in /libs/go-kibana-rest (#1481)
  Bump golang.org/x/crypto from 0.42.0 to 0.45.0 (#1480)
  fix(deps): update module github.com/go-resty/resty/v2 to v2.17.0 (#1478)
  chore(deps): update kibana-openapi-spec digest to f1d0789 (#1479)
  chore(deps): update kibana-openapi-spec digest to 5841714 (#1477)
  chore(deps): update golang:1.25.4 docker digest to 6981837 (#1476)
  chore(deps): update kibana-openapi-spec digest to 67de5ef (#1475)
  chore(deps): update golangci/golangci-lint-action digest to e7fa5ac (#1474)
  chore(deps): update kibana-openapi-spec digest to b4553b6 (#1472)
  chore(deps): update actions/checkout action to v6 (#1470)
  Support publishing experimental resources/datasources within the framework provider (#1464)
  chore(deps): update actions/setup-go digest to 4dc6199 (#1466)
  fix(deps): update module github.com/elastic/elastic-transport-go/v8 to v8.8.0 (#1459)
  Prepare 0.12.2 Release (#1458)
  Support spaces for detection rules (#1457)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] .gen-ai and AWS Bedrock .bedrock missing as valid connector ids for elasticstack_kibana_action_connector

2 participants