Add security list resource

[nick-benoit]

Adds Security List resource Docs.

This is supporting work for Security Exceptions.

On it's own this resource is not tremendously useful, but will quickly be followed by PRs for the following:

• Security List Items
• Security Exceptions

[nick-benoit]

@copilot Implement the above suggestions

[Copilot]

@nick-benoit I've opened a new pull request, #1490, to work on those changes. Once the pull request is ready, I'll request review from you.

[nick-benoit]

Copilot kept suggesting that I use the create / update response instead of doing a secondary read. Adding this seems to help with that.

[Copilot]

Pull request overview

Copilot reviewed 22 out of 24 changed files in this pull request and generated 3 comments.

[tobio]

Suggested change

	return resp, nil
	return resp.JSON200, nil

Does it make sense to return the parsed response models from these helpers?

[nick-benoit]

I think it does. I may opt to do that refactor in the list item PR though for the sake of easily pulling these changes into that dependent PR.

[tobio]

We have this pattern a lot where the API returns a custom string type and so we can't use types.StringPointerValue.

Want to create a new typesutil package with something like:

func StringishPointerValue[T ~string](ptr *T) types.String {
	if ptr == nil {
		return types.StringNull()
	}
	return types.StringValue(string(*ptr))
}

so this code can just be

Suggested change

	if apiList.UnderscoreVersion != nil {
	m.VersionID = types.StringValue(string(*apiList.UnderscoreVersion))
	} else {
	m.VersionID = types.StringNull()
	}
	m.VersionID = typesutil.StringishPointerValue(apiList.UnderscoreVersion)

[nick-benoit]

It seemed like these utilities fit pretty well into the existing utils/utils.go file. Happy to add a dedicated package if you prefer that though.

52c50ba

[tobio]

Happy to leave this for a follow up PR. A catch-all utils package is discouraged by the Golang gods, so I was thinking we could start moving these TF type specific helpers to a dedicated typeutils package.

[nick-benoit]

I'll make a note and add that to the security list item PR 👍

[nick-benoit]

@tobio FYI I realized while adding an import test that we were not using the internal composite ID properly. I just pushed that up in this commit: 20b443d

[tobio]

One last change

[tobio]

We don't need the if/else for these with this new helper

Suggested change

	if apiList.Deserializer != nil {
	m.Deserializer = utils.StringishPointerValue(apiList.Deserializer)
	} else {
	m.Deserializer = types.StringNull()
	}
	m.Deserializer = utils.StringishPointerValue(apiList.Deserializer)

[nick-benoit]

Ahh good call: 1907787

[tobio]

🎉