Refactor security list resource to address review feedback

[Copilot]

Addresses three structural issues in the security list resource implementation based on code review feedback.

Changes

• Refactored optimistic locking in update.go: Pass version_id directly from state to toUpdateRequest() instead of copying to plan. The copy was redundant since the subsequent read overwrites it anyway.

• Fixed id attribute schema: Made id Computed-only per Terraform conventions. Clarified that id is the internal resource identifier while list_id is the user-facing Kibana identifier (optionally user-specified or auto-generated).

• Removed version from update requests: The version field is server-managed and distinct from _version (version_id) used for optimistic locking. Sending both could cause conflicts.

Example

// Before: Unnecessary copy to plan
plan.VersionID = state.VersionID
updateReq, _ := plan.toUpdateRequest()

// After: Direct pass from state
updateReq, _ := plan.toUpdateRequest(state.VersionID.ValueString())

---

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.