Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overview Pagination: add ability to specify N of rows/page #122

Closed
SlavikCA opened this issue Dec 2, 2019 · 6 comments
Closed

Overview Pagination: add ability to specify N of rows/page #122

SlavikCA opened this issue Dec 2, 2019 · 6 comments
Labels
enhancement New feature or request

Comments

@SlavikCA
Copy link

SlavikCA commented Dec 2, 2019

7.5.0 added Pagination to the overview page.
However, it always 10 rows per page.
Doesn't look good on my 32" 4k monitor.
Previously (without pagination) I can overview all of my entries by opening one page by one click. Now it takes me a few clicks to load a few pages.

Request:

  • Add the ability to specify N rows per page. With one choice being "All rows"
  • Add the ability to make it default. Either by storing the preference in the cookie or by specifying as URI parameter.
@SlavikCA
Copy link
Author

SlavikCA commented Dec 2, 2019

Here is how it looks on my large monitor:

Screen Shot 2019-12-02 at 3 09 26 PM

@SlavikCA SlavikCA changed the title Pagination: add ability to specify N of rows/page Pagination overview: add ability to specify N of rows/page Dec 2, 2019
@SlavikCA SlavikCA changed the title Pagination overview: add ability to specify N of rows/page Overview Pagination: add ability to specify N of rows/page Dec 2, 2019
@andrewvc
Copy link
Contributor

andrewvc commented Dec 3, 2019

Thanks for the suggestion @SlavikCA , I think this makes sense, except the 'All Rows' part. That could be quite intense performance-wise if you have 10k+ rows etc.

@andrewvc andrewvc added the enhancement New feature or request label Dec 3, 2019
@SlavikCA
Copy link
Author

SlavikCA commented Dec 3, 2019

this makes sense, except the 'All Rows' part. That could be quite intense performance-wise if you have 10k+ rows etc.

In the "10k+ rows" case you just will not select 'All Rows'.
In the previous version (7.4) 'All Rows' was the default. Why we can't have it as an option now?

@andrewvc
Copy link
Contributor

andrewvc commented Dec 3, 2019

In 7.4 all rows wasn't truly all rows. We had a limit built into the server, and it would just select at most that limit. Unbounded data fetching isn't something we can build without causing crashes or adverse performance.

@andrewvc
Copy link
Contributor

andrewvc commented Jan 6, 2020

I've created elastic/kibana#54031 to track work on this issue in greater detail, I'm going to close this issue in favor of that more action oriented one.

@andrewvc
Copy link
Contributor

Fixed in elastic/kibana#60573

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants