Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements elasticio 3094 graceful process shutdown #134



Copy link

VitaliyKovalchuk commented Feb 12, 2020

tests todo:

  • start, no messages, shutdown
    • should shutdown instantly
  • start, one message, short processing, shutdown
    • should shutdown shortly
  • start, one message, long processing, shutdown
    • should shutdown after processing
  • start, two messages, long processing, shutdown between messages processing
    • should shutdown after processing of the first message
  • start, two messages, wait for the first message processed, shutdown
    • should shutdown after processing of the last messagetoo hard to implement
  • start, two messages, wait for the all messages processed, shutdown
    • should shutdown shortlytoo hard to implement
  • start, one message, long processing, shutdown, enqueue few more messages
    • should shutdown after the first message processed, other messages should not be consumedtoo hard to implement
yarikos and others added 15 commits Jan 23, 2020
add amqp.listenQueueCancel method
create dir integration_helpers instead of integration_helpers.js;
add Sintegration_helper/shellTester.js;
few fixes in integration_helpers.amqp;
add integration_helpers.fakeApiServerStart – real express.js server since nock could not be used in the child_process;
fix logger – it considers LOG_LEVEL even when NODE_ENV=test.
    fixed codestyle;
    fixed bug in `sailor.scheduleShutdown` with missing Promise when `scheduleShutdown` were called multiple times; added test for this;
    fixed test for `amqp.disconnect` with missing `await amqp.disconnect()`.
@VitaliyKovalchuk VitaliyKovalchuk requested a review from PaulAnnekov Feb 12, 2020
@VitaliyKovalchuk VitaliyKovalchuk merged commit e7566b9 into master Feb 14, 2020
3 checks passed
3 checks passed
ci/circleci Your tests passed on CircleCI!
continuous-integration/travis-ci/pr The Travis CI build passed
continuous-integration/travis-ci/push The Travis CI build passed
@VitaliyKovalchuk VitaliyKovalchuk deleted the implements-elasticio-3094_graceful_process_shutdown branch Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.