Fixed typescript build #420
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dusanradovanovic
requested review from
aChanEP,
petro97,
rostyk-kanafotskyy,
shaunmaharaj and
yulia-dnistrian
Contributor
|
No further comments. Thanks @dusanradovanovic! |
shaunmaharaj
approved these changes
Sep 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR fixes the issue with the TypeScript build. Prior to this TypeScript errors were going undetected due to the wrong configuration in webpack.config (not including all projects) as well as due to using of "files" properties in tsconfig.json (which limits compiling only to the files listed there). This PR includes all files back into compilation process as well as fixing all existing errors so that build works again.
Linting:
Component Updates:
Tests:
e2e)Documentation: