Skip to content

Conversation

@rostyk-kanafotskyy
Copy link
Contributor

@rostyk-kanafotskyy rostyk-kanafotskyy commented May 19, 2020

Description:

Installed core and interactions modules separately

Brfore:
AWS amplify - 690kb + GraphQl - 530kb (used by amplify for API calls that we don't use)
image

After:
AWS amplify - 140kb
image

Let me know if I miss something 🙂

Linting:

  • No linting errors

Tests:

  • E2E tests (npm test run with e2e)
  • Manual tests
  • Accessibility tests (no new react-axe errors in console)

Documentation:

  • Requires documentation updates
  • Requires Storybook component updates

@rostyk-kanafotskyy rostyk-kanafotskyy self-assigned this May 19, 2020
@rostyk-kanafotskyy rostyk-kanafotskyy changed the title RS-831 Optimized was-amplify lib RS-831 Optimized aws-amplify lib May 19, 2020
Copy link
Contributor

@aChanEP aChanEP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@shaunmaharaj shaunmaharaj merged commit c422cf6 into master May 19, 2020
@shaunmaharaj shaunmaharaj deleted the RS-831-optimize-amplify branch May 19, 2020 14:15
shaunmaharaj added a commit that referenced this pull request May 21, 2020
shaunmaharaj added a commit that referenced this pull request May 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants