Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "ok" : true from successful REST responses #4310

Closed
kimchy opened this issue Dec 2, 2013 · 2 comments
Closed

Remove "ok" : true from successful REST responses #4310

kimchy opened this issue Dec 2, 2013 · 2 comments
Assignees
@dakrone
Labels
>breaking v1.0.0.RC1

Comments

@kimchy
Copy link
Member

kimchy commented Dec 2, 2013

Its pretty meaningless, especially with correct REST codes. Also, we are not consistent in returning it in all APIs. I suggest we simply remove it.
@jprante
Copy link
Contributor

jprante commented Dec 2, 2013

+1

@dakrone dakrone mentioned this issue Dec 4, 2013
Closed
@ghost ghost assigned dakrone Dec 6, 2013
@dakrone
Copy link
Member

dakrone commented Jan 7, 2014

Merged in d23f640

@dakrone dakrone closed this as completed Jan 7, 2014
javanna added a commit that referenced this issue Jan 16, 2014
@javanna
[DOCS] updated json responses after #4310 and #4480
4126ae2 
 - Removed "ok": true from response examples
 - Added "created" flag to index response examples
 - Replaced exists flag with found in delete response examples
brusic pushed a commit to brusic/elasticsearch that referenced this issue Jan 19, 2014
@javanna @brusic
[DOCS] updated json responses after elastic#4310 and elastic#4480
017d958 
 - Removed "ok": true from response examples
 - Added "created" flag to index response examples
 - Replaced exists flag with found in delete response examples
meveridge added a commit to meveridge/SugarES that referenced this issue Feb 13, 2014
@meveridge
Change Connection check from ok to status
81ed549 
ES 1.0.0 removed the ok result from connection:

elastic/elasticsearch#4310

Changed to check is the status array islet and equals 200.
@prestonp prestonp mentioned this issue Feb 20, 2014
Merged
@sigmarstern sigmarstern mentioned this issue Feb 25, 2014
Closed
@grantr grantr mentioned this issue Apr 9, 2014
Closed
olimcc pushed a commit to olimcc/elastisch that referenced this issue Apr 16, 2014
Update created? check for new API compatabiity.
fbfd43d 
The new ES API removed :ok <bool> from rest responses and instead relies on
a :status <status code>. See: elastic/elasticsearch#4310
for the corresponding ES change.

Updates to related code and and some tests.
@olimcc olimcc mentioned this issue Apr 16, 2014
Merged
mreishus pushed a commit to AudiologyHoldings/Icing that referenced this issue Apr 29, 2014
ElasticSearchRequest: ES1.0 no longer returns "ok" in responses
74e8f4f 
See elastic/elasticsearch#4310

The code that checks for a 200 response code will pick up any errors.
scorphus added a commit to scorphus/tornado-es that referenced this issue Apr 30, 2014
@scorphus
Support changes in ES since version 1.0
53badd2 
Changes:

 * Adapt ESConnection.count() to use a top-level `query` parameter
 * Use `term` query instead of `text`
 * Don't expect a hard-coded `"ok": true` from response

References:

 * http://www.elasticsearch.org/guide/en/elasticsearch/reference/1.x/breaking-changes.html
 * http://www.elasticsearch.org/guide/en/elasticsearch/reference/1.x/_return_values.html#_return_values
 * http://www.elasticsearch.org/guide/en/elasticsearch/reference/1.x/_search_requests.html#_search_requests
 * elastic/elasticsearch#4033
 * elastic/elasticsearch#4310

Thanks @luizgpsantos for estensive support
@scorphus scorphus mentioned this issue Apr 30, 2014
Merged
@lukas-vlcek lukas-vlcek mentioned this issue Sep 16, 2014
Closed
stefankeidel pushed a commit to collectiveaccess/providence that referenced this issue Oct 8, 2014
NOJIRA Fix ElasticSearch event logging
fbeb675 
They removed the hardcoded ok: true in their responses a while ago:
elastic/elasticsearch#4310

We now use HTTP status codes to determine if everything went ok. We
also catch all exceptions now. Before the whole application would just
barf if ElasticSearch went away.
@kehh kehh mentioned this issue Apr 28, 2015
Merged
dirkraft added a commit to blacklocus/jres that referenced this issue Sep 14, 2015
@dirkraft
Update elasticsearch and all dependencies. Start fixes
98b7948 
one of which is elastic/elasticsearch#4310 "no more ok in elasticsearch responses"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dakrone dakrone

Labels
>breaking v1.0.0.RC1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove hard-coded "ok": true from REST responses dakrone/elasticsearch
3 participants
@dakrone @kimchy @jprante