Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Zen Discovery references deprecated ping_timeout setting #9908

Closed
pickypg opened this issue Feb 26, 2015 · 3 comments
Closed

[Docs] Zen Discovery references deprecated ping_timeout setting #9908

pickypg opened this issue Feb 26, 2015 · 3 comments
Assignees
Labels
>docs General docs changes good first issue low hanging fruit help wanted adoptme

Comments

@pickypg
Copy link
Member

pickypg commented Feb 26, 2015

http://www.elasticsearch.org/guide/en/elasticsearch/reference/current/modules-discovery-zen.html#master-election

As part of the ping process a master of the cluster is either elected or joined to. This is done automatically. The discovery.zen.ping_timeout (which defaults to 3s)

This is still true, but the setting should be discovery.zen.ping.timeout.

@pickypg pickypg added >docs General docs changes good first issue low hanging fruit help wanted adoptme labels Feb 26, 2015
@vedil
Copy link

vedil commented Jun 8, 2015

i see in code "ZenDiscovery.java" that both properties are used and "discovery.zen.ping.timeout" over-rides " discovery.zen.ping_timeout"
below is the code snippet:
TimeValue pingTimeout = this.settings.getAsTime("discovery.zen.initial_ping_timeout", timeValueSeconds(3));
pingTimeout = this.settings.getAsTime("discovery.zen.ping_timeout", pingTimeout);
pingTimeout = settings.getAsTime("discovery.zen.ping_timeout", pingTimeout);
this.pingTimeout = settings.getAsTime(SETTING_PING_TIMEOUT, pingTimeout);

@pickypg
Copy link
Member Author

pickypg commented Jun 10, 2015

Hi @vedil, I definitely agree that that's in the code, but the SETTING_PING_TIMEOUT is the last one, which means that it gets the final say-so.

@jasontedor
Copy link
Member

Closed by d8b29f7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>docs General docs changes good first issue low hanging fruit help wanted adoptme
Projects
None yet
Development

No branches or pull requests

3 participants