Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENGINE] Fix updates dynamic settings in InternalEngineHolder #8885

Merged
merged 1 commit into from Dec 10, 2014

Conversation

s1monw
Copy link
Contributor

@s1monw s1monw commented Dec 10, 2014

After the refactoring in #8784 some settings didn't get passed to the
actual engine and there exists a race if the settings are updated while
the engine is started such that the actual starting engine doesn't see
the latest settings. This commit fixes the concurrency issue as well as
adds tests to ensure the settings are reflected.

here is an example of the concurrency issue
http://build-us-00.elasticsearch.org/job/es_core_1x_suse/166/

[node_s2] [test][0] updating index.fail_on_corruption from [false] to [true]

... but further down we see

[node_s2] [test][0] corrupt file detected source: [recovery phase 1] but [index.fail_on_corruption] is set to [false]

@s1monw s1monw added the review label Dec 10, 2014
@mikemccand
Copy link
Contributor

LGTM

After the refactoring in elastic#8784 some settings didn't get passed to the
actual engine and there exists a race if the settings are updated while
the engine is started such that the actual starting engine doesn't see
the latest settings. This commit fixes the concurrency issue as well as
adds tests to ensure the settings are reflected.
@s1monw s1monw merged commit f308049 into elastic:master Dec 10, 2014
@s1monw s1monw removed the review label Dec 10, 2014
@s1monw s1monw deleted the fix_engine_update_setttings branch December 10, 2014 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants