adr:Allow Ingress config snippet annotations #401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cristiklein
reviewed
Sep 13, 2022
lucianvlad
force-pushed
the
lucian/allow-ingress-config-snippet-annotations
branch
from
f051ec3
to
22c2d4b
Compare
lucianvlad
requested review from
davidumea,
llarsson,
OlleLarsson and
cristiklein
davidumea
approved these changes
Sep 13, 2022
OlleLarsson
reviewed
Sep 13, 2022
OlleLarsson
approved these changes
Sep 13, 2022
OlleLarsson
reviewed
Sep 13, 2022
llarsson
approved these changes
Sep 13, 2022
There was a problem hiding this comment.
I generally approve, but think it is also a bit strange to have a canned message in the ADR itself.
I would have preferred to have that outside of the architectural decision as a general principle. It provides good material for further reading and such, though.
lucianvlad
force-pushed
the
lucian/allow-ingress-config-snippet-annotations
branch
from
22c2d4b
to
41ed7bb
Compare
|
@lucianvlad Forgot to mention, before merging, please regenerate the index, as described here. |
lucianvlad
force-pushed
the
lucian/allow-ingress-config-snippet-annotations
branch
from
41ed7bb
to
b292f35
Compare
Done just now |
lucianvlad
deleted the
lucian/allow-ingress-config-snippet-annotations
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ADR : Allow Ingress config snippet annotations