Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix restart_nonblocking error, add integer address mode #4

Merged
merged 3 commits into from Sep 2, 2020
Merged

Fix restart_nonblocking error, add integer address mode #4

merged 3 commits into from Sep 2, 2020

Conversation

ryankurte
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Aug 16, 2020 •
edited

Coverage Status

Coverage decreased (-1.7%) to 93.933% when pulling 36f758c on ryankurte:fix-async-add-addr into 9db5039 on eldruin:master.

eldruin
eldruin requested changes Aug 16, 2020
View reviewed changes
Copy link
Owner

@eldruin eldruin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR!

src/device_impl.rs Show resolved Hide resolved
src/types.rs Outdated Show resolved Hide resolved
@eldruin
Copy link
Owner

eldruin commented Sep 2, 2020

Ah, another great use for Into<>. Thanks!
Is this now ready for merge or do you want to add something else?

@ryankurte
Copy link
Contributor Author

it's a neat trick hey! i think that's all atm

@eldruin eldruin merged commit 2cb2cec into eldruin:master Sep 2, 2020
@eldruin
Copy link
Owner

eldruin commented Sep 2, 2020

Thank you! I will post here once I get this released.

@eldruin
Copy link
Owner

eldruin commented Sep 3, 2020

I have released this in version 0.3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eldruin eldruin eldruin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ryankurte @coveralls @eldruin