Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saving feedback is updating all students grades #61

Closed
crystalvaughn opened this issue Sep 11, 2020 · 7 comments
Closed

Saving feedback is updating all students grades #61

crystalvaughn opened this issue Sep 11, 2020 · 7 comments

Comments

@crystalvaughn
Copy link

When a journal has multiple entries made by students. If a teacher grades one student journal it updates the other students grades to 0 in the gradebook. Previously the teacher was able to grade one student and saving the feed back would only update the one student.

Steps to recreate:

  1. Log on a Moodle course
  2. Create a journal activity
  3. Log in as student1 and enter a journal entry.
  4. Log in as student2 and enter a journal entry.
  5. Log in as student3 and enter a journal entry.
  6. Log in as the teacher in the course and view the journal entries.
  7. Add feedback and a score to student1's journal entry.
  8. Click the submit all feedback.
  9. All the students feedback and grades are updated.
@amandadoughty
Copy link
Contributor

The rating has a default value of null. If no grade is set in the feedback form then the submitted rating is set to -1. A comparison of null and -1 then sets the logic to upgrade the entry.

I propose changing the rating default to -1. I will provide a fix if this an acceptable solution for the dev team?

@will-bulluck
Copy link

I have a client experiencing the same issue on MOODLE_35

@will-bulluck
Copy link

Any update on this?

@larsbonczek
Copy link

We have encountered this issue in Moodle 3.9. The solution suggested by amandadoughty works for us. Could it please be merged?

@will-bulluck
Copy link

Any updates to this?

@will-bulluck
Copy link

Any Update on this?

lucaboesch pushed a commit to lucaboesch/moodle-mod_journal that referenced this issue Jan 26, 2022
lucaboesch pushed a commit to lucaboesch/moodle-mod_journal that referenced this issue Jan 26, 2022
lucaboesch pushed a commit to lucaboesch/moodle-mod_journal that referenced this issue Jan 26, 2022
lucaboesch pushed a commit to lucaboesch/moodle-mod_journal that referenced this issue Jan 26, 2022
@adrian-sarmas
Copy link
Collaborator

I've merged the pull request. Thanks for helping!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants