From bb8d86f99bafabf3119b08113d8d1f02160b2ab3 Mon Sep 17 00:00:00 2001 From: electric-el Date: Thu, 19 May 2022 16:53:10 -0400 Subject: [PATCH] fixes per linter --- scripts/classes/code-viewer.js | 7 +++---- scripts/listeners/code-viewer.js | 9 +++++++++ 2 files changed, 12 insertions(+), 4 deletions(-) diff --git a/scripts/classes/code-viewer.js b/scripts/classes/code-viewer.js index 63260c5..e954785 100644 --- a/scripts/classes/code-viewer.js +++ b/scripts/classes/code-viewer.js @@ -66,6 +66,8 @@ export default class CodeViewer { this.$orgs['#patternlab-body'].dispatchAction('removeClass', 'viewall'); } + let dockOpen; + switch (data.event) { case 'patternlab.keyPress': switch (data.keyPress) { @@ -314,9 +316,6 @@ export default class CodeViewer { return this.setPanelContent(type) .then(() => this.gitPullMarkdown()); } - - /* istanbul ignore next */ - break; } default: { return this.setPanelContent(type, this.patternPartial); @@ -821,7 +820,7 @@ export default class CodeViewer { const sgCodeContainerState = this.$orgs['#sg-code-container'].getState(); if (!sgCodeContainerState.classArray.includes('active')) { - return + return; } const sgCodeTabState = this.$orgs['.sg-code-tab'].getState(); diff --git a/scripts/listeners/code-viewer.js b/scripts/listeners/code-viewer.js index ea6b14f..b03ab6a 100644 --- a/scripts/listeners/code-viewer.js +++ b/scripts/listeners/code-viewer.js @@ -243,6 +243,9 @@ export default class CodeViewer { if (dockOpen) { this.#fepperUi.viewerHandler.dockLeft(); } + + e.preventDefault(); + return false; }); // Dock Code Viewer to the bottom. @@ -252,6 +255,9 @@ export default class CodeViewer { if (dockOpen) { this.#fepperUi.viewerHandler.dockBottom(); } + + e.preventDefault(); + return false; }); // Dock Code Viewer to the right. @@ -261,6 +267,9 @@ export default class CodeViewer { if (dockOpen) { this.#fepperUi.viewerHandler.dockRight(); } + + e.preventDefault(); + return false; }); } }