Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PersistentStorage::RestoreDefaults causes crashes #504

Closed
stephenhensley opened this issue Mar 23, 2022 · 0 comments · Fixed by #517
Closed

PersistentStorage::RestoreDefaults causes crashes #504

stephenhensley opened this issue Mar 23, 2022 · 0 comments · Fixed by #517
Labels
bug Something isn't working

Comments

@stephenhensley
Copy link
Collaborator

I think this is vestigial from a previous version of the class that worked on a reference to the initial struct passed in to initialization.

Pretty sure this can be resolved just by changing

*settings = default_settings;

to

settings = default_settings;

However, I'm not 100% sure if the default copy operator will work or not. So we should test it.
@stephenhensley stephenhensley added the bug Something isn't working label Mar 23, 2022
stephenhensley pushed a commit that referenced this issue Apr 28, 2022
fixed #504 - copy operator for actual struct, not pointer to it
9697525
@stephenhensley stephenhensley mentioned this issue Apr 28, 2022
Merged
stephenhensley added a commit that referenced this issue Apr 28, 2022
@stephenhensley
Fix PersistentStorage crash when calling RestoreDefaults (#517)
e12fb04 
* fixed #504 - copy operator for actual struct, not pointer to it

* fixed style

Co-authored-by: stephenhensley <stephen.p.hensley@gmail.com>
stephenhensley added a commit that referenced this issue Apr 29, 2022
@stephenhensley
User callbacks to timer peripheral (#518)
f22b751 
* fixed #504 - copy operator for actual struct, not pointer to it

* added user-callbacks to timer peripheral

* changed systick NVIC priority to second to last priority so we can have IRQs with lower priority if we want.

* fixed style

* added enable_irq member of callback.'

* documentation clean up and todo-organization

Co-authored-by: stephenhensley <stephen.p.hensley@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix PersistentStorage crash when calling RestoreDefaults electro-smith/libDaisy
1 participant
@stephenhensley