New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not link with libnotify #221

Merged
merged 2 commits into from May 17, 2016

Conversation

Projects
None yet
2 participants
@zcbenz
Contributor

zcbenz commented May 17, 2016

We are already loading it dynamically there is no meaning linking with the library anymore.

Close electron/electron#5348.

zcbenz added some commits May 17, 2016

@zcbenz zcbenz merged commit 248d422 into master May 17, 2016

@zcbenz zcbenz deleted the no-link-libnotify branch May 17, 2016

@paulcbetts

This comment has been minimized.

Contributor

paulcbetts commented May 18, 2016

This seems to break debug build:

.a /home/paul/code/electron/electron/vendor/brightray/vendor/download/libchromiumcontent/shared_library/libcdm_renderer.a /home/paul/code/electron/electron/vendor/brightray/vendor/download/libchromiumcontent/shared_library/libsecurity_state.a -ldl
obj/vendor/brightray/browser/linux/brightray.libnotify_loader.o: In function `LibNotifyLoader::Load(std::string const&)':
../../vendor/brightray/browser/linux/libnotify_loader.cc:(.text+0x186): undefined reference to `notify_is_initted'
../../vendor/brightray/browser/linux/libnotify_loader.cc:(.text+0x1d2): undefined reference to `notify_init'
../../vendor/brightray/browser/linux/libnotify_loader.cc:(.text+0x221): undefined reference to `notify_get_server_info'
../../vendor/brightray/browser/linux/libnotify_loader.cc:(.text+0x270): undefined reference to `notify_get_server_caps'
../../vendor/brightray/browser/linux/libnotify_loader.cc:(.text+0x2bf): undefined reference to `notify_notification_new'
../../vendor/brightray/browser/linux/libnotify_loader.cc:(.text+0x30e): undefined reference to `notify_notification_add_action'
../../vendor/brightray/browser/linux/libnotify_loader.cc:(.text+0x35d): undefined reference to `notify_notification_set_image_from_pixbuf'
../../vendor/brightray/browser/linux/libnotify_loader.cc:(.text+0x3ac): undefined reference to `notify_notification_set_timeout'
../../vendor/brightray/browser/linux/libnotify_loader.cc:(.text+0x3fb): undefined reference to `notify_notification_set_hint_string'
../../vendor/brightray/browser/linux/libnotify_loader.cc:(.text+0x44a): undefined reference to `notify_notification_show'
../../vendor/brightray/browser/linux/libnotify_loader.cc:(.text+0x499): undefined reference to `notify_notification_close'
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment