Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

Revert "Replace --whole-archive with --start-group" #229

Merged
merged 1 commit into from
Jun 23, 2016
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions brightray.gyp
Original file line number Diff line number Diff line change
Expand Up @@ -36,13 +36,14 @@
'conditions': [
# Link with libraries of libchromiumcontent.
['OS=="linux" and libchromiumcontent_component==0', {
# On Linux we have to use "--start-group" or we will have plenty of
# On Linux we have to use "--whole-archive" to force executable
# to include all symbols, otherwise we will have plenty of
# unresolved symbols errors.
'link_settings': {
'libraries': [
'-Wl,--start-group',
'direct_dependent_settings': {
'ldflags': [
'-Wl,--whole-archive',
'<@(libchromiumcontent_libraries)',
'-Wl,--end-group'
'-Wl,--no-whole-archive',
],
}
}, { # (Release build on Linux)
Expand Down