New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow delegate to handle file and color chooser #238

Merged
merged 1 commit into from Jul 25, 2016

Conversation

Projects
None yet
2 participants
@deepak1556
Contributor

deepak1556 commented Jul 22, 2016

Fixes electron/electron#6156

A side note,

  • should WebDialogHelper::EnumerateDirectory required to be enumerate over DIRECTORIES, INCLUDE_DOT_DOT when its not recursive ?
  • The current implementation causes render to terminate with RVH_CAN_ACCESS_FILES_OF_PAGE_STATE because of INCLUDE_DOT_DOT in the result.
  • Can we make the enumeration async using net::DirectoryLister or is the current implementation fine ?
@zcbenz

This comment has been minimized.

Contributor

zcbenz commented Jul 25, 2016

👍

@zcbenz zcbenz merged commit fa17fc6 into electron-archive:master Jul 25, 2016

@zcbenz

This comment has been minimized.

Contributor

zcbenz commented Jul 25, 2016

should WebDialogHelper::EnumerateDirectory required to be enumerate over DIRECTORIES, INCLUDE_DOT_DOT when its not recursive ?

The current implementation causes render to terminate with RVH_CAN_ACCESS_FILES_OF_PAGE_STATE because of INCLUDE_DOT_DOT in the result.

We should probably follow what Chromium does.

Can we make the enumeration async using net::DirectoryLister or is the current implementation fine ?

It would be much better.

So far no one actually complained about our dialog implementation, we can maybe wait unless someone complains.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment