New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set dock state using devtools dockController #254

Merged
merged 1 commit into from Oct 10, 2016

Conversation

Projects
None yet
3 participants
@deepak1556
Contributor

deepak1556 commented Oct 6, 2016

settings query param was removed in https://codereview.chromium.org/2177983004 , hence our dock state was not respected. We now directly set the dock state using WebInspector.dockController.setDockSide api since it seems more reliable.

Fixes electron/electron#7503

@zcbenz

This comment has been minimized.

Show comment
Hide comment
@zcbenz

zcbenz Oct 10, 2016

Contributor

👍

Contributor

zcbenz commented Oct 10, 2016

👍

@zcbenz zcbenz merged commit abae71b into electron-archive:master Oct 10, 2016

@kevinsawicki

This comment has been minimized.

Show comment
Hide comment
@kevinsawicki

kevinsawicki Oct 10, 2016

Member

Are you able to update the dock side and have it persist across relaunches/reopens?

I'm seeing it go to the right side every time using the default app. Even after I set it to go to the bottom, then close it, it opens the next time on the right side again.

Member

kevinsawicki commented Oct 10, 2016

Are you able to update the dock side and have it persist across relaunches/reopens?

I'm seeing it go to the right side every time using the default app. Even after I set it to go to the bottom, then close it, it opens the next time on the right side again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment