New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iconUrl should accept local files #73

Closed
romaincointepas opened this Issue Oct 29, 2015 · 5 comments

Comments

Projects
None yet
5 participants
@romaincointepas
Copy link

romaincointepas commented Oct 29, 2015

setupIcon does accept a local .ico file, is there any reason why it can't be the same for iconUrl (which should just be named icon then)?

@paulcbetts

This comment has been minimized.

Copy link
Contributor

paulcbetts commented Oct 29, 2015

If you use a local .ico file, it'll only work on your computer - the Squirrel installer downloads the icon for the uninstaller on-install. This isn't ideal, but it's how it works right now

@d9k

This comment has been minimized.

Copy link

d9k commented Mar 2, 2016

If you use a local .ico file, it'll only work on your computer

So why can't icon be distributed with application package?

the Squirrel installer downloads the icon for the uninstaller on-install

Why can't icon be integrated into installer?

@paulcbetts

This comment has been minimized.

Copy link
Contributor

paulcbetts commented Mar 2, 2016

Because IconURL is a URL, and if you specify things that aren't URLs, NuGet will blow up. I suppose we could try a file: URL but that'd be quite unintuitive for people

@lipis

This comment has been minimized.

Copy link

lipis commented Mar 2, 2016

@paulcbetts anything.. as long as we can assign some sort of icon to local path :)

@havenchyk

This comment has been minimized.

Copy link
Collaborator

havenchyk commented Apr 14, 2016

Well, it's not possible right now because of nuget limitations. Feel free to open issue agains nuget or squirrel.windows.

@havenchyk havenchyk closed this Apr 14, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment