Skip to content
Permalink
Browse files

feat(appx): attempt to use identityName for manifest name

It is very useful to set a custom `identityName` when the name of the
app in package.json contains hyphens (which are not permitted in
`appxmanifest.yml`).

Even if you set a non-hyphenated name as `identityName`,
electron-builder will still use the package.json's `name` property for
the `name` appxmanifest.yml value.

Thus, we attempt to re-use `identityName` for that case as well.

Signed-off-by: Juan Cruz Viotti <jv@jviotti.com>
  • Loading branch information...
jviotti committed Aug 12, 2017
1 parent 022d542 commit 220cf6f3465586038bcef365763bc09e33c995da
Showing with 1 addition and 1 deletion.
  1. +1 −1 packages/electron-builder/src/targets/appx.ts
@@ -125,7 +125,7 @@ export default class AppXTarget extends Target {
return appInfo.versionInWeirdWindowsForm

case "name":
return appInfo.name
return options.identityName || appInfo.name

case "identityName":
return options.identityName || appInfo.name

0 comments on commit 220cf6f

Please sign in to comment.
You can’t perform that action at this time.