From 4a177dc01c9119443426f1eb500afb836fd4f381 Mon Sep 17 00:00:00 2001 From: Mike Maietta Date: Wed, 28 Jul 2021 14:06:04 -0700 Subject: [PATCH] fix(mac): signing cert filter incorrectly selects certificates (#6094) (#6101) (#6105) * fix(mac): Adding Developer ID Application entry for development signing when not mas (#6094) * fix(mac): Removing 3rd Party Mac Developer Application certificate selector (#6101) --- .changeset/great-pumas-trade.md | 6 ++++++ packages/app-builder-lib/src/macPackager.ts | 4 ++-- 2 files changed, 8 insertions(+), 2 deletions(-) create mode 100644 .changeset/great-pumas-trade.md diff --git a/.changeset/great-pumas-trade.md b/.changeset/great-pumas-trade.md new file mode 100644 index 0000000000..8fee6e3fe4 --- /dev/null +++ b/.changeset/great-pumas-trade.md @@ -0,0 +1,6 @@ +--- +"app-builder-lib": patch +--- + +fix(mac): Adding Developer ID Application entry for development signing when building not a mas target. Fixes: #6094 +fix(mac): Removing 3rd Party Mac Developer Application certificate selector. Fixes: #6101 diff --git a/packages/app-builder-lib/src/macPackager.ts b/packages/app-builder-lib/src/macPackager.ts index 8555547446..9b373bd388 100644 --- a/packages/app-builder-lib/src/macPackager.ts +++ b/packages/app-builder-lib/src/macPackager.ts @@ -453,7 +453,7 @@ export default class MacPackager extends PlatformPackager { function getCertificateTypes(isMas: boolean, isDevelopment: boolean): CertType[] { if (isDevelopment) { - return ["Mac Developer", "Apple Development"] + return isMas ? ["Mac Developer", "Apple Development"] : ["Developer ID Application"] } - return isMas ? ["3rd Party Mac Developer Application", "Apple Distribution"] : ["Developer ID Application"] + return isMas ? ["Apple Distribution"] : ["Developer ID Application"] }