-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build with codesign takes a long time when 'nodegit' is in my dependencies #1147
Comments
When I
So it looks like codesign is going deep into hidden folders, including VCS databases, and signing all of those entries too. That's a lot to sign. Which explains the wait. My workaround is to add some
First I exclude the whole I did this through trial and error, so my file patterns are probably excluding some critical file. But this at least gets the build working, and I don't initially see any problems with |
I think it's unlikely there will be a lot of commentary on this one, so I'm going to close it. |
@matthewtoast No, it will be investigated and fixed when I will have time :) |
Solution — do not use npm. Use yarn and execute |
I have a similar problem, but I don't want to use For me codesign, the final package
|
Yes, such files must be signed. Because it is library. |
You can try to add ignores to files option if some files are not required for you. |
Curious if this still applies in 2019? Apparently https://yarnpkg.com/lang/en/docs/cli/autoclean/ is the current command and there are separate packages that can accomplish this for npm users such as https://github.com/tj/node-prune |
BREAKING CHANGE:⚠️ You must uninstall the previous version to avoid any conflicts. For users: - New installer/uninstaller with customizable installation path - Better night mode - Release tab has been deleted - Apply on [...] are now in the preset tabs with more options - Notifications are now handled within the app/system accordingly to the app's minimized state For developers: - Now using React and TypeScript - Switched from npm to yarn: electron-userland/electron-builder#1147 (comment) - Updated Continuous Delivery to GitLab v12.7.0
BREAKING CHANGE: ⚠ Please avoid using v1 and v2 simultaneously. This version is stable enough to be released but is still under heavy development, **You may encounter bugs, if you encounter any, you can uninstall this version and go back to v1.** For users: - Users can now share presets and vote for them. - New installer/uninstaller with customizable installation path - #66 Add multi-language: English, Français, 简体中文, Deutsch, Türkçe. - Presets triggers are now in preset tabs with more options - Added splash screen - Better night mode - Release tab now open browser - Notifications are now handled within the app/system accordingly to the app's minimized state For developers: - Now using React and TypeScript - Switched from npm to yarn: electron-userland/electron-builder#1147 (comment) - Updated Continuous Delivery Contributors: @rikoopa @Jamiexhz @Silvaburn#3669
Has this been sorted? I couldn't make it the codesign complete |
Problem:
I am trying to build a project that has
nodegit@0.16.0
as a dependency. When I run:The build takes a long time (i.e. never finishes). On my MacBook Pro (Retina, Mid 2012) running MacOS Sierra, the "Rebuilding" and "Packaging" steps take ~5 minutes, which is a bit slow. For the "Signing" step, however, I've waited 30+ minutes and never seen it finish.
With
nodegit
deleted from"dependencies"
, the build finishes in seconds.Details:
A minimal package.json that reproduces the issue looks like this:
(To repro the signing slowness, you would need to get a developer certificate, etc.)
Hypotheses:
Based on the output of
$ ps ax | grep codesign
while running the build, my guess is that there are simply so many files to sign that it is just taking a long time. I see it signing a lot of files that seem ancillary.With that in mind, these are my hypotheses:
I am supposed to somehow pre-bundle my code before using
electron-builder
. (I.e. concatenate my JavaScript files, etc., so that there are fewer files to sign?)I am supposed to configure the
"files"
build option so that code-signing doesn't have to trawl through a bunch of ancillary files. (It looks likenodegit
and its dependencies are rather huge, and there are some test/VCS artifacts also being signed.)I have misconfigured the installation of
nodegit
somehow, resulting in a big complicated bundle.I am supposed to pre-compile
nodegit
down to a single bundle before using it here.Waiting over 30 minutes in my scenario is normal. This is simply a fact of life I will have to accept if I want to include
nodegit
in my project.I am supposed to use the two-package.json setup.
Am I onto something with any of these? Any tips or suggestions?
Apologies if I've missed some important note in the documentation that pertains to this.
The text was updated successfully, but these errors were encountered: