New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nsis-web appPackageUrl property causes 404 error on web installer #1810

Closed
xavero opened this Issue Jul 10, 2017 · 4 comments

Comments

Projects
None yet
2 participants
@xavero

xavero commented Jul 10, 2017

  • Version: 19.13.0

  • Target: nsis and nsis-web

When I define the appPackageUrl property in nsis-web section, the web installer cannot download the 7zip files, because the installer script don't append the filenames to the Package Url

Example:

  • git clone https://github.com/xavero/electron-boilerplate
  • run:
    npm install && npm run installer
  • start a web server on dist folder and download Electron Boilerplate Web Setup 0.0.0.exe
  • Run the installer to see the error of file not found

xavero added a commit to xavero/electron-builder that referenced this issue Jul 10, 2017

fix (nsis-web): package url incomplete when using appPackageUrl prope…
…rty in config

Installer did not find the file to download when using appPackageUrl, because the installer
script was missing the file name.
Fix electron-userland#1810

@develar develar added the bug label Jul 25, 2017

@develar

This comment has been minimized.

Member

develar commented Jul 25, 2017

Sorry for late response. It is by design, in the docs "URL like https://example.com/download/latest allows web installer to be version independent (installer will download latest application package).".

To provide own url — configure publish. e.g. generic provider.

{
  "provider": "generic",
  "url": "your url"
}

@develar develar closed this Jul 25, 2017

@develar develar added question and removed bug labels Jul 25, 2017

@xavero

This comment has been minimized.

xavero commented Jul 25, 2017

Sorry, didn't notice was by design.
Can I change my PR to expose APP_PACKAGE_URL_IS_INCOMPLETE in some way ?

In my case I don't have full control of the server, so I cannot send the correct zip file (ia32 or x64) for the client installer, since I cannot read the header of the request.

I had to created 2 JSON config files, one for the NSIS Full Setup and another for the NSIS Web, and run the packaging 2 times.

@develar

This comment has been minimized.

Member

develar commented Jul 25, 2017

@xavero You are not forced to specify publish options for all targets. Simply specify it in the nsisWeb and it will be applied only for web installer. Is it ok for you?

@xavero

This comment has been minimized.

xavero commented Jul 25, 2017

I feel dumb now.. I didn't realize that publish options was also a property for the nsis and nsisWeb targets... I was only setting in the root level.

Yes, I think that will work for me. Thanks for all the help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment