New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NSIS] `runAfterFinish: false` not working when `oneClick: true` #2951

Closed
wojtkowiak opened this Issue May 25, 2018 · 5 comments

Comments

Projects
None yet
2 participants
@wojtkowiak
Contributor

wojtkowiak commented May 25, 2018

  • Version:
    20.14.7
  • Target:
    NSIS

For quite some time I had:

oneClick: true,
runAfterFinish: false

as I want to build a simple installer but I need the app to not start at the end.
I see that from 20.13.5 the runAfterFinish(RUN_AFTER_FINISH) is not taken into account: edb82af

I did check the corresponding tasks for this PR but I do not get the picture what exactly was fixed there and whether removing runAfterFinish was intended or not.

Anyway let me know if we can restore it, or how can I achieve the previous effect 🙂

@wojtkowiak wojtkowiak changed the title from [NSIS] runAfterFinish not working when `oneClick: true` to [NSIS] `runAfterFinish: false` not working when `oneClick: true` May 25, 2018

@develar

This comment has been minimized.

Member

develar commented May 25, 2018

It is bug, fixed, will be released soon.

@develar develar added bug nsis labels May 25, 2018

@develar develar closed this May 25, 2018

@develar

This comment has been minimized.

Member

develar commented May 25, 2018

20.15.1

@wojtkowiak

This comment has been minimized.

Contributor

wojtkowiak commented May 25, 2018

Thanks a lot!

@wojtkowiak

This comment has been minimized.

Contributor

wojtkowiak commented May 28, 2018

Sorry to bothering you once again but I have two problems after updating to 10.5.2.
When building with my meteor-desktop now the installation is stuck at packaging - it waits there indefinitely (waited 30 min) - it seems to be a issue with the new copyNodeModules - I will check it out more in detail in a moment.
I did remove that commit and tested the fix but the installer now does not close itself, I guess the

!ifdef ONE_CLICK
  !ifdef RUN_AFTER_FINISH
    ${ifNot} ${Silent}
    ${orIf} ${isForceRun}
      !insertmacro doStartApp
    ${endIf}

    !insertmacro quitSuccess
  !endif
!else

should be this way:

!ifdef ONE_CLICK
  !ifdef RUN_AFTER_FINISH
    ${ifNot} ${Silent}
    ${orIf} ${isForceRun}
      !insertmacro doStartApp
    ${endIf}
  !endif
  !insertmacro quitSuccess
!else
@wojtkowiak

This comment has been minimized.

Contributor

wojtkowiak commented May 28, 2018

About the first issue, it gets stuck here:
await executeAppBuilder(["node-dep-tree", "--dir", platformPackager.info.appDir])

Probably this should not be invoked at all as I do not have node_modules at this point.
Can I do a PR with a similar check for node_modules like we did here? (I guess I can just add it to this if)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment