New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different Icon for installer / App ? (Windows) #525

Closed
kunkinkan opened this Issue Jun 18, 2016 · 15 comments

Comments

Projects
None yet
2 participants
@kunkinkan

kunkinkan commented Jun 18, 2016

I use a white icon because it looks good in windows, but the installer has then a white-on-grey icon which is nearly invisible. Is it possible to use a different icon inside the installer window? (but not in the dock)?

Also, the icon in the upper left corner of any windows app, has a white background, is it possible to use a different icon for that too?

@develar

This comment has been minimized.

Show comment
Hide comment
@develar

develar Jun 19, 2016

Member

NSIS — cannot reproduce. Or do you mean to use different installer icon?

Please attach screenshots, I am not windows expert.

Member

develar commented Jun 19, 2016

NSIS — cannot reproduce. Or do you mean to use different installer icon?

Please attach screenshots, I am not windows expert.

@develar develar added the windows label Jun 19, 2016

@develar

This comment has been minimized.

Show comment
Hide comment
@develar

develar Jun 19, 2016

Member

As far I understand, windows uses the same icon for task bar and window bar, but I am not expert, help wanted.

Member

develar commented Jun 19, 2016

As far I understand, windows uses the same icon for task bar and window bar, but I am not expert, help wanted.

@kunkinkan

This comment has been minimized.

Show comment
Hide comment
@kunkinkan

kunkinkan Jun 19, 2016

Yes, I mean the icon that is shown in the installer, above the progress bar. Since my icon is white, on the light gray background of the installer window it almost looks invisible. Same for the icon in the window bar, but that I don't know if it's possible to change. Installer matter most.

kunkinkan commented Jun 19, 2016

Yes, I mean the icon that is shown in the installer, above the progress bar. Since my icon is white, on the light gray background of the installer window it almost looks invisible. Same for the icon in the window bar, but that I don't know if it's possible to change. Installer matter most.

@kunkinkan

This comment has been minimized.

Show comment
Hide comment
@kunkinkan

kunkinkan commented Jun 19, 2016

http://stackoverflow.com/questions/7431039/how-to-replace-the-default-logo-in-nsis-installer - this may work but don't know if it works with your splash screen.

@develar

This comment has been minimized.

Show comment
Hide comment
@develar

develar Jun 20, 2016

Member

Solution found — we use SpiderBanner plugin instead of splash, it is in 5.5. Installer icon and uninstaller will be customizable, you can expect fix on this week.

Member

develar commented Jun 20, 2016

Solution found — we use SpiderBanner plugin instead of splash, it is in 5.5. Installer icon and uninstaller will be customizable, you can expect fix on this week.

@kunkinkan

This comment has been minimized.

Show comment
Hide comment
@kunkinkan

kunkinkan Jun 20, 2016

Cool you're so fast, and this is done for free, its unbelievable. You should put up a donate page or something. Just to be clear, the icon shown INSIDE the installer window (above progress bar) can be different from the icon shown in the start menu bar / dock (however you call it in windows) (from that same installer) ? I'd like my white transparent icon to show in the windows dock, but the black one to show in the installer window itself.

kunkinkan commented Jun 20, 2016

Cool you're so fast, and this is done for free, its unbelievable. You should put up a donate page or something. Just to be clear, the icon shown INSIDE the installer window (above progress bar) can be different from the icon shown in the start menu bar / dock (however you call it in windows) (from that same installer) ? I'd like my white transparent icon to show in the windows dock, but the black one to show in the installer window itself.

@develar

This comment has been minimized.

Show comment
Hide comment
@develar

develar Jun 24, 2016

Member

We use SpiderBanner plugin, MUI_HEADERIMAGE_BITMAP is not supported.

    /*  Set the icon on our dialog. It retrieves the icon from the installer resources. */
    SendDlgItemMessage(hwndDlg, 1025, STM_SETICON, (WPARAM)(HICON)LoadIcon(GetModuleHandle(NULL), MAKEINTRESOURCE(103)), 0);

http://forums.winamp.com/showthread.php?p=3061114#post3061114

Member

develar commented Jun 24, 2016

We use SpiderBanner plugin, MUI_HEADERIMAGE_BITMAP is not supported.

    /*  Set the icon on our dialog. It retrieves the icon from the installer resources. */
    SendDlgItemMessage(hwndDlg, 1025, STM_SETICON, (WPARAM)(HICON)LoadIcon(GetModuleHandle(NULL), MAKEINTRESOURCE(103)), 0);

http://forums.winamp.com/showthread.php?p=3061114#post3061114

@develar develar added the nsis label Jun 24, 2016

develar added a commit to develar/electron-builder that referenced this issue Jun 24, 2016

develar added a commit to develar/electron-builder that referenced this issue Jun 24, 2016

@kunkinkan

This comment has been minimized.

Show comment
Hide comment
@kunkinkan

kunkinkan Jun 24, 2016

Not supported but you are supporting it anyway it seems? What should the size be of that bmp? (Does it need to be bmp?)

kunkinkan commented Jun 24, 2016

Not supported but you are supporting it anyway it seems? What should the size be of that bmp? (Does it need to be bmp?)

@develar

This comment has been minimized.

Show comment
Hide comment
@develar

develar Jun 24, 2016

Member

@kunkinkan Supported only for boring installer, not for one-click. I will wait SpiderBanner plugin change — see http://forums.winamp.com/showthread.php?p=3061117#post3061117

What should the size be of that bmp?

See example https://media.githubusercontent.com/media/electron-userland/electron-builder/master/test/fixtures/test-app-one/installerHeader.bmp

Regular icon converted to bmp will not work.

(Does it need to be bmp?)

Yes.

Member

develar commented Jun 24, 2016

@kunkinkan Supported only for boring installer, not for one-click. I will wait SpiderBanner plugin change — see http://forums.winamp.com/showthread.php?p=3061117#post3061117

What should the size be of that bmp?

See example https://media.githubusercontent.com/media/electron-userland/electron-builder/master/test/fixtures/test-app-one/installerHeader.bmp

Regular icon converted to bmp will not work.

(Does it need to be bmp?)

Yes.

develar added a commit to develar/electron-builder that referenced this issue Jun 26, 2016

@develar develar closed this in 65650ea Jun 26, 2016

@kunkinkan

This comment has been minimized.

Show comment
Hide comment
@kunkinkan

kunkinkan Jun 26, 2016

I place headerIcon.ico in the build directory, but it doesn't seem to be used. Default still is. (Yes, one-click installer).

kunkinkan commented Jun 26, 2016

I place headerIcon.ico in the build directory, but it doesn't seem to be used. Default still is. (Yes, one-click installer).

@develar

This comment has been minimized.

Show comment
Hide comment
@develar

develar Jun 26, 2016

Member

I suppose that installerHeader is also specified? In the 5.9.0 there is a bug that headerIcon.ico is not checked if installerHeader specified, it is already fixed.

Member

develar commented Jun 26, 2016

I suppose that installerHeader is also specified? In the 5.9.0 there is a bug that headerIcon.ico is not checked if installerHeader specified, it is already fixed.

@kunkinkan

This comment has been minimized.

Show comment
Hide comment
@kunkinkan

kunkinkan Jun 26, 2016

No, i only have

    "win": {
      "target": "nsis"
    },

kunkinkan commented Jun 26, 2016

No, i only have

    "win": {
      "target": "nsis"
    },

@develar develar reopened this Jun 27, 2016

@develar

This comment has been minimized.

Show comment
Hide comment
@develar

develar Jun 27, 2016

Member

@kunkinkan please try 5.10.0

Member

develar commented Jun 27, 2016

@kunkinkan please try 5.10.0

@kunkinkan

This comment has been minimized.

Show comment
Hide comment
@kunkinkan

kunkinkan Jun 27, 2016

Seems to make no difference.

kunkinkan commented Jun 27, 2016

Seems to make no difference.

@develar

This comment has been minimized.

Show comment
Hide comment
@develar

develar Jun 28, 2016

Member

Renamed to installerHeaderIcon and fixed (http://forums.winamp.com/showpost.php?p=3061392&postcount=32).

Member

develar commented Jun 28, 2016

Renamed to installerHeaderIcon and fixed (http://forums.winamp.com/showpost.php?p=3061392&postcount=32).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment