New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NSIS windows 10 desktop shortcut icon missing #865

Closed
emilyplusplus opened this Issue Oct 31, 2016 · 12 comments

Comments

Projects
None yet
2 participants
@emilyplusplus

emilyplusplus commented Oct 31, 2016

  • 7.15.2:
  • Windows 10:

When using NSIS to create a windows single click installer it creates a desktop icon with a blank icon and that doesn't work, i.e. it points to nowhere and doesn't launch app when you click it. See image:
screen shot 2016-10-31 at 3 22 03 pm

screen shot 2016-10-31 at 3 29 00 pm

I have sniffed around nsh scripts and don't see anything weird about desktop icon, and I should note that the start menu icon and shortcut works fine, it's only the desktop shortcut that has this issue. Tried running installer as admin too, same issues. Tried compatibility mode and that has the same issue too.

"build": { "appId": "com.domain.application", "linux": [ "AppImage", "deb", "rpm" ], "win": { "target": "nsis" } }

@develar

This comment has been minimized.

Member

develar commented Oct 31, 2016

Please try to restart Windows.

@emilyplusplus

This comment has been minimized.

emilyplusplus commented Oct 31, 2016

The issue persists after restart as well

@emilyplusplus

This comment has been minimized.

emilyplusplus commented Nov 1, 2016

Were you able to reproduce the issue?

@develar

This comment has been minimized.

Member

develar commented Nov 1, 2016

@embeddedemily Not yet. My test apps work for me. If you can attach here your project / link to repo — it will help me to reproduce the issue.

@emilyplusplus

This comment has been minimized.

emilyplusplus commented Nov 1, 2016

I can't do that unfortunately, since it's a private repo which I do not have rights to share. Let me investigate as well on my end. I'll try making brand new sample app and packaging it up and see what happens.

Another possible helpful detail: I don't use the two package.json build system I only have one json file. Maybe that makes a difference

@develar

This comment has been minimized.

Member

develar commented Nov 2, 2016

Could you please try run your installer on another machine?

since it's a private repo which I do not have rights to share

Is it possible to send me only installer?

@develar develar added the reply-needed label Nov 2, 2016

@emilyplusplus

This comment has been minimized.

emilyplusplus commented Nov 2, 2016

I tested installer on two other windows 7 machines and both had same issue where icon would appear on desktop with right app name but wrong icon and the link path would be blank. I might be able to give installer (I believe we're still in discussion as to whether installer for our app will be freely available for download online. But I'd rather try and work it out without at first.

I made brand new electron app, simply cloned electron-quick-start repo, added electron builder as follows:

{ "name": "electron-quick-start", "version": "1.0.0", "description": "A minimal Electron application", "main": "main.js", "scripts": { "start": "electron ." }, "repository": "https://github.com/electron/electron-quick-start", "keywords": [ "Electron", "quick", "start", "tutorial", "demo" ], "author": "GitHub", "license": "CC0-1.0", "devDependencies": { "electron": "^1.4.1", "electron-builder": "^7.14.1" }, "scripts": { "pack": "build --dir", "dist": "build" }, "build": { "appId": "com.redpillanalytics.checkmate", "linux": [ "AppImage" ], "win": { "target": "nsis" } } }

And ran "npm run dist" on my windows 10 virtual machine which gave me the installer which I ran and got the following:

screen shot 2016-11-02 at 4 19 13 pm

screen shot 2016-11-02 at 4 19 28 pm

It appears as though it is at least linking and putting icon in this instance but it's still the wrong icon and appears to link the folder from which I ran the installer rather than the folder where it installed to on the local machine: C:\Users\Emily\AppData\Local\Programs\electron-quick-start

But again on windows machine start menu shortcut it perfect.

@emilyplusplus

This comment has been minimized.

emilyplusplus commented Nov 2, 2016

@develar I suspect the issue is target path based and not truly with the icon. That is to say the reason I got a blank white icon in my first case was because the target path was completely blank. Yet with the last case for simple test case I do get a folder icon which would be appropriate considering it's pointing to a folder. But the question becomes why is it pointing to a folder and not the install path and subsequently the executable. Because my guess would be once target path is present icon will display properly.

@develar

This comment has been minimized.

Member

develar commented Nov 3, 2016

Relates #864

@develar develar added investigate nsis and removed reply-needed labels Nov 3, 2016

@develar

This comment has been minimized.

Member

develar commented Nov 3, 2016

Ouch. If you use Parallels, you must not use "Share Mac user folders with Windows" feature and must not run installers from such folders. I am also macOS user and Parallels user and aware about this problem. I didn't report about it to Parallels, if you want – please report (but I guess it is Windows bug).

You should or use feature "Open in Windows"
screen shot 2016-11-03 at 11 14 33

or copy installer to windows machine.

@develar develar added windows and removed investigate labels Nov 3, 2016

@develar develar closed this Nov 3, 2016

@emilyplusplus

This comment has been minimized.

emilyplusplus commented Nov 3, 2016

@develar worked like a charm when I disabled that feature! thanks a ton for your help!

@develar

This comment has been minimized.

Member

develar commented Nov 3, 2016

@embeddedemily Yep. Thanks for confirmation. I didn't report to Parallels since this feature is nightmare in any case and should be disabled in any case. Maybe this feature is ok for dummy home users, but for developers it is no-no.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment