New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: how to generate a token and export to travis and appveyor #487

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@rafajaques

rafajaques commented Jun 10, 2016

I had some trouble while trying to figure out how to properly set GH_TOKEN in Travis and AppVeyor.
So I decided to add some instructions in Wiki.

@develar

This comment has been minimized.

Member

develar commented Jun 10, 2016

Thanks for your contribution, docs is very important.

We recommend to use UI to add env on CI. https://github.com/electron-userland/electron-builder/wiki/Code-Signing#travis-appveyor-and-other-ci-servers (step 3 "Set CSC_LINK and CSC_KEY_PASSWORD"). I think, we should merge this info and extract it to a new document.

@rafajaques

This comment has been minimized.

rafajaques commented Jun 11, 2016

What do you suggest?
Creating a page for CI servers?

@develar

This comment has been minimized.

Member

develar commented Jun 13, 2016

What do you suggest?

I suggest to extract information how to set env using UI from Code-Signing to separate page (create new page). And add link to such page to Publishing Artifacts page.

@rafajaques

This comment has been minimized.

rafajaques commented Jun 21, 2016

I exported GH_TOKEN in Travis UI and everything went fine.
But in Appveyor it didn't work. It seems that the variable was not exported.
Any tips on that? Or should we use "encrypt data" in Appveyor?

@develar

This comment has been minimized.

Member

develar commented Jun 21, 2016

@rafajaques "In case of AppVeyor, don't forget to click on lock icon to “Toggle variable encryption”.

@rafajaques

This comment has been minimized.

rafajaques commented Jun 21, 2016

Isn't that so?

captura de tela 2016-06-21 as 13 38 46

@develar

This comment has been minimized.

Member

develar commented Jun 21, 2016

@rafajaques Should be ok. Please open issue and attach log, clarify "it didn't work".

@rafajaques

This comment has been minimized.

rafajaques commented Jun 21, 2016

I'm rebuilding to see if it works.

@rafajaques

This comment has been minimized.

rafajaques commented Jun 21, 2016

Nevermind. It was a problem related to publishing windows --ia32 and --x64 at the same time.
Now that I have everything setup, I'll be back to docs.

@jwheare

This comment has been minimized.

Contributor

jwheare commented Jul 1, 2016

FWIW, I ended up writing a very similar version of these docs (with more code signing specifics) for our project here: https://github.com/irccloud/irccloud-desktop/blob/master/docs/OfficialBuilds.md

@develar develar closed this Oct 31, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment