Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use tag name instead of version when resolving GitHub files #6117

Merged
merged 2 commits into from Aug 1, 2021

Conversation

@wardellbagby
Copy link
Contributor

@wardellbagby wardellbagby commented Jul 31, 2021

Modify the GitHubProvider to provide the tag name of the latest
release as apart of its UpdateInfo (which is now encapsulated in the
GithubUpdateInfo interface) so that it uses that same tag name later
when it resolves the files to download.

fix /issues/6076

@changeset-bot
Copy link

@changeset-bot changeset-bot bot commented Jul 31, 2021

⚠️ No Changeset found

Latest commit: 069facb

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Loading

@mmaietta
Copy link
Collaborator

@mmaietta mmaietta commented Jul 31, 2021

Nice work! Thanks for contributing!

Loading

@mmaietta
Copy link
Collaborator

@mmaietta mmaietta commented Jul 31, 2021

Please double-check the GitHub-related tests when you can

 FAIL  src/updater/nsisUpdaterTest.ts
  ✕ downgrade (disallowed, beta) (254 ms)
  ✕ file url github (261 ms)
  ✕ file url github pre-release and fullChangelog (38 ms)

    HttpError: 404 Not Found
    "method: GET url: https://github.com/develar/__test_nsis_release/releases/download/1.5.2-beta.3/latest.yml\n\

Loading

@wardellbagby
Copy link
Contributor Author

@wardellbagby wardellbagby commented Jul 31, 2021

Kinda took a guess as to whether y'all were rebase or merge folks and just rebased. Hope you don't mind!

Loading

@wardellbagby wardellbagby requested a review from mmaietta Jul 31, 2021
@wardellbagby
Copy link
Contributor Author

@wardellbagby wardellbagby commented Jul 31, 2021

Oops, missed some tests. Fixing...

Loading

wardellbagby and others added 2 commits Jul 31, 2021
Modify the GitHubProvider to provide the tag name of the latest
release as apart of its UpdateInfo (which is now encapsulated in the
GithubUpdateInfo interface) so that it uses that same tag name later
when it resolves the files to download.

fix electron-userland/issues/6076
@wardellbagby
Copy link
Contributor Author

@wardellbagby wardellbagby commented Jul 31, 2021

Sorry for the fix-test-push loop here; I can't run all of the tests locally. 😭

Loading

@mmaietta mmaietta merged commit dcf03a6 into electron-userland:master Aug 1, 2021
5 checks passed
Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants