Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace deprecated --cache-min option #6165

Conversation

@mhatvan
Copy link
Contributor

@mhatvan mhatvan commented Aug 18, 2021

Closes #6130

I found out on https://docs.npmjs.com/cli/v7/using-npm/config#cache-min that we can replace deprecated --cache-min with --prefer-offline to avoid pnpm install failure.

This is the commit where pnpm added support for --prefer-offline: pnpm/pnpm@b553c5c

- replace deprecated --cache-min with --prefer-offline to avoid pnpm install failure
@changeset-bot
Copy link

@changeset-bot changeset-bot bot commented Aug 18, 2021

🦋 Changeset detected

Latest commit: c1d9236

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
app-builder-lib Patch
dmg-builder Patch
electron-builder-squirrel-windows Patch
electron-builder Patch
electron-forge-maker-appimage Patch
electron-forge-maker-nsis-web Patch
electron-forge-maker-nsis Patch
electron-forge-maker-snap Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Loading

@mhatvan mhatvan marked this pull request as ready for review Aug 18, 2021
@mmaietta mmaietta merged commit c02ccbb into electron-userland:master Aug 20, 2021
7 checks passed
Loading
@mhatvan
Copy link
Contributor Author

@mhatvan mhatvan commented Aug 20, 2021

Great to see this merged!

Can we expect a new release soonish?

Loading

@mmaietta
Copy link
Collaborator

@mmaietta mmaietta commented Aug 22, 2021

Released 🙂

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants