Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(windows): detect node path correctly on windows with cross-spawn (#6069) #6172

Merged
merged 5 commits into from Aug 22, 2021

Conversation

@Losses
Copy link
Contributor

@Losses Losses commented Aug 21, 2021

This Pull request would fix #6069

@changeset-bot
Copy link

@changeset-bot changeset-bot bot commented Aug 21, 2021

🦋 Changeset detected

Latest commit: aac9218

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 10 packages
Name Type
builder-util Patch
app-builder-lib Patch
dmg-builder Patch
electron-builder-squirrel-windows Patch
electron-builder Patch
electron-publish Patch
electron-forge-maker-appimage Patch
electron-forge-maker-nsis-web Patch
electron-forge-maker-nsis Patch
electron-forge-maker-snap Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Loading

@Losses Losses changed the title Fix #6069 fix: fix #6069 Aug 21, 2021
@mmaietta
Copy link
Collaborator

@mmaietta mmaietta commented Aug 21, 2021

Nice detective work!

Do we need to worry about a similar issue in NsisUpdater using child_process?

const process = spawn(exe, args, {
detached: true,
stdio: "ignore",
})

Loading

@mmaietta mmaietta changed the title fix: fix #6069 fix(windows): detect node path correctly on windows with cross-spawn (#6069) Aug 21, 2021
@mmaietta
Copy link
Collaborator

@mmaietta mmaietta commented Aug 21, 2021

Please take a look at the failing tests:

Error: Cannot spawn /__w/electron-builder/electron-builder/node_modules/.pnpm/app-builder-bin@3.7.1/node_modules/app-builder-bin/linux/x64/app-builder: TypeError: cross_spawn_1.default is not a function

Loading

@Losses
Copy link
Contributor Author

@Losses Losses commented Aug 22, 2021

Nice detective work!

Do we need to worry about a similar issue in NsisUpdater using child_process?

const process = spawn(exe, args, {
detached: true,
stdio: "ignore",
})

I think these code doesn't need to be modified, I didn't find any error in this place when I packaged our application.

Loading

@mmaietta mmaietta merged commit 6c945bd into electron-userland:master Aug 22, 2021
7 checks passed
Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants