Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Adding snapStore to AllPublishOptions for generating Configuration schema #6193

Merged

Conversation

@mmaietta
Copy link
Collaborator

@mmaietta mmaietta commented Aug 27, 2021

Adding snapStore to AllPublishOptions for generating Configuration schema
fixes: #6190

@changeset-bot
Copy link

@changeset-bot changeset-bot bot commented Aug 27, 2021

🦋 Changeset detected

Latest commit: b723378

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 12 packages
Name Type
app-builder-lib Patch
builder-util-runtime Patch
dmg-builder Patch
electron-builder-squirrel-windows Patch
electron-builder Patch
electron-forge-maker-appimage Patch
electron-forge-maker-nsis-web Patch
electron-forge-maker-nsis Patch
electron-forge-maker-snap Patch
builder-util Patch
electron-publish Patch
electron-updater Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Loading

@mmaietta mmaietta merged commit 7f933d0 into electron-userland:master Aug 27, 2021
7 checks passed
Loading
@mmaietta mmaietta deleted the fix/snapStore-config-schema branch Aug 27, 2021
@github-actions github-actions bot mentioned this pull request Aug 27, 2021
@@ -5287,7 +5292,8 @@
}
},
"required": [
"provider"
"provider",
"repo"
Copy link
Contributor

@lutzroeder lutzroeder Oct 12, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmaietta This should be channels instead of repo according to documentation?

#6327

Loading

Copy link
Collaborator Author

@mmaietta mmaietta Oct 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is actually autogenerated via pnpm run schema
The main location we need to change is making the repo optional and regenerating the schema

export interface SnapStoreOptions extends PublishConfiguration {
/**
* The provider. Must be `snapStore`.
*/
readonly provider: "snapStore"
/**
* snapcraft repo name
*/
readonly repo: string
/**
* The list of channels the snap would be released.
* @default ["edge"]
*/
readonly channels?: string | Array<string> | null
}

Loading

Copy link
Contributor

@lutzroeder lutzroeder Oct 13, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants