fix: restore duplicate dependency and workspace tree resolution#9548
Merged
Conversation
🦋 Changeset detectedLatest commit: c28269f The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
mmaietta
changed the title
|
No dependency changes detected. Learn more about Socket for GitHub. 👍 No dependency changes detected in pull request |
When a duplicate dependency is detected (has _dependencies but empty dependencies), we now: - Fetch the complete tree from allDependencies.get(dependencyId) - Use this tree for both dependencies and _dependencies checks - This ensures we filter against matching _dependencies, preventing the "too many files" issue
mmaietta
force-pushed
the
fix/json-parsing-node-collector
branch
from
7878b9a to
abacdfa
Compare
This was
linked to
issues
Jan 31, 2026
…-parsing-node-collector
mmaietta
force-pushed
the
fix/json-parsing-node-collector
branch
from
e172610 to
c28269f
Compare
mmaietta
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Key Changes
Return tree within workspace instead of pruning:
Partial revert of PR #9380 to be able reduce dependencies being bundled. Updated test to validate native module compilation and runtime during e2e updater test.
Duplicate Dependency Handling
When a duplicate dependency is detected (with
_dependenciesbut emptydependencies), we now:allDependencies.get(dependencyId)dependenciesand_dependencieschecks_dependencies, preventing the "too many files" issueCollector Parsing
The
trim()is to handle odd edge case where pnpm outputs something unparseable on a per-line basis. yarn v1 already had this logic, this is replicating it for base collector's bracket-counting.Added additional args for
loglevel=errorto help reduce console pollution and follow the optimal code-pathExample: https://github.com/electron-userland/electron-builder/actions/runs/21449112753/job/61772893356
[Functional Tests] Lockfile stub
Adding a stub lockfile, if none already exists, during test setup to prevent flaky package manager prompts/warnings/errors (such as yarn v1
No lockfile found.error).Example: https://github.com/electron-userland/electron-builder/actions/runs/21546118903/job/62087715031
Should fix:
#9532
#9545