Skip to content

chore(tests): migrate to only programmatic vitest API#9571

Merged
mmaietta merged 9 commits into
electron-userland:masterfrom
mmaietta:chore/programmatic-vitest
Feb 7, 2026
Merged

chore(tests): migrate to only programmatic vitest API#9571
mmaietta merged 9 commits into
electron-userland:masterfrom
mmaietta:chore/programmatic-vitest

Conversation

@mmaietta
Copy link
Copy Markdown
Collaborator

@mmaietta mmaietta commented Feb 7, 2026

This PR inadvertently resolves a few issues.

  • test duration is properly tracked on a per-test basis, and does not fall back to module duration
  • updated logging from listing all test files scanned, to only those that are post-filter/included
  • fixes vitest watch mode (it actually works now?!)
  • switching to programmatic API also fixes snapshot diff console output (for some reason running via subprocess doesn't pipe through snapshot diffs)
  • no longer leaves straggling vitest workers on process cancel/kill (my laptop can die in peace now)

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Feb 7, 2026

⚠️ No Changeset found

Latest commit: 5ed1b84

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@socket-security
Copy link
Copy Markdown

socket-security Bot commented Feb 7, 2026

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedelectron@​23.2.0949010098100
Addednode-mac-permissions@​2.3.07410010079100
Addedyargs@​17.7.29910010087100
Addednode-pty@​1.1.0-beta149310010095100

View full report

@socket-security
Copy link
Copy Markdown

socket-security Bot commented Feb 7, 2026

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action Severity Alert  (click "▶" to expand/collapse)
Warn High
High CVE: npm qs's arrayLimit bypass in its bracket notation allows DoS via memory exhaustion

CVE: GHSA-6rw7-vpxm-498p qs's arrayLimit bypass in its bracket notation allows DoS via memory exhaustion (HIGH)

Affected versions: < 6.14.1

Patched version: 6.14.1

From: ?npm/qs@6.5.3

ℹ Read more on: This package | This alert | What is a CVE?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Remove or replace dependencies that include known high severity CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/qs@6.5.3. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn High
High CVE: npm semver vulnerable to Regular Expression Denial of Service

CVE: GHSA-c2qf-rxjj-qqgw semver vulnerable to Regular Expression Denial of Service (HIGH)

Affected versions: >= 7.0.0 < 7.5.2; >= 6.0.0 < 6.3.1; >= 2.0.0-alpha < 5.7.2

Patched version: 5.7.2

From: ?npm/semver@5.3.0

ℹ Read more on: This package | This alert | What is a CVE?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Remove or replace dependencies that include known high severity CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/semver@5.3.0. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn High
High CVE: npm semver vulnerable to Regular Expression Denial of Service

CVE: GHSA-c2qf-rxjj-qqgw semver vulnerable to Regular Expression Denial of Service (HIGH)

Affected versions: >= 7.0.0 < 7.5.2; >= 6.0.0 < 6.3.1; >= 2.0.0-alpha < 5.7.2

Patched version: 6.3.1

From: ?npm/electron@23.2.0npm/semver@6.3.0

ℹ Read more on: This package | This alert | What is a CVE?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Remove or replace dependencies that include known high severity CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/semver@6.3.0. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn High
High CVE: npm semver vulnerable to Regular Expression Denial of Service

CVE: GHSA-c2qf-rxjj-qqgw semver vulnerable to Regular Expression Denial of Service (HIGH)

Affected versions: >= 7.0.0 < 7.5.2; >= 6.0.0 < 6.3.1; >= 2.0.0-alpha < 5.7.2

Patched version: 7.5.2

From: ?npm/electron@23.2.0npm/semver@7.3.8

ℹ Read more on: This package | This alert | What is a CVE?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Remove or replace dependencies that include known high severity CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/semver@7.3.8. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn Medium
Deprecated by its maintainer: npm core-js

Reason: core-js@<3.23.3 is no longer maintained and not recommended for usage due to the number of issues. Because of the V8 engine whims, feature detection in old core-js versions could cause a slowdown up to 100x even if nothing is polyfilled. Some versions have web compatibility issues. Please, upgrade your dependencies to the actual version of core-js.

From: ?npm/core-js@1.2.7

ℹ Read more on: This package | This alert | What is a deprecated package?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Research the state of the package and determine if there are non-deprecated versions that can be used, or if it should be replaced with a new, supported solution.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/core-js@1.2.7. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn Medium
Deprecated by its maintainer: npm uuid

Reason: Please upgrade to version 7 or higher. Older versions may use Math.random() in certain circumstances, which is known to be problematic. See https://v8.dev/blog/math-random for details.

From: ?npm/uuid@3.4.0

ℹ Read more on: This package | This alert | What is a deprecated package?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Research the state of the package and determine if there are non-deprecated versions that can be used, or if it should be replaced with a new, supported solution.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/uuid@3.4.0. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

@mmaietta mmaietta merged commit de82d5e into electron-userland:master Feb 7, 2026
36 checks passed
@mmaietta mmaietta deleted the chore/programmatic-vitest branch February 7, 2026 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant