Skip to content
Permalink
Browse files

fix(plugin-webpack): adjust publicPath in renderer only (#1035)

This reverts improper PR#1021 and re-implements the changes I have in the JS (compiled) code at the right place.

Fixes #1034.
  • Loading branch information
shimaore authored and malept committed Jul 17, 2019
1 parent ca6ed54 commit 57ca285abb3074da3797935af366e65cdd747ac3
Showing with 2 additions and 2 deletions.
  1. +2 −2 packages/plugin/webpack/src/WebpackPlugin.ts
@@ -333,7 +333,7 @@ Your packaged app may be larger than expected if you dont ignore everything othe
path: path.resolve(this.baseDir, 'renderer'),
filename: '[name]/index.js',
globalObject: 'self',
publicPath: '/',
...(this.isProd ? {} : { publicPath: '/' }),
},
node: {
__dirname: false,
@@ -425,7 +425,7 @@ Your packaged app may be larger than expected if you dont ignore everything othe
error: tab.log.bind(tab),
warn: tab.log.bind(tab),
},
...(this.isProd ? {} : { publicPath: '/' }),
publicPath: '/',
hot: true,
historyApiFallback: true,
writeToDisk: true,

0 comments on commit 57ca285

Please sign in to comment.
You can’t perform that action at this time.