Skip to content
Permalink
Browse files

fix(core): allow multiple plugins, fix bad startLogic check

  • Loading branch information
MarshallOfSound committed Jun 4, 2018
1 parent 1b7e411 commit 9164ec518c611a6ca61b69f2b12e88df7568d98f
Showing with 4 additions and 2 deletions.
  1. +2 −1 packages/api/core/package.json
  2. +2 −1 packages/api/core/src/util/plugin-interface.ts
@@ -42,6 +42,7 @@
"@electron-forge/installer-rpm": "6.0.0-beta.16",
"@electron-forge/installer-zip": "6.0.0-beta.16",
"@electron-forge/maker-base": "6.0.0-beta.16",
"@electron-forge/plugin-base": "^6.0.0-beta.16",
"@electron-forge/publisher-base": "6.0.0-beta.16",
"@electron-forge/shared-types": "6.0.0-beta.16",
"colors": "^1.2.0",
@@ -66,4 +67,4 @@
"engines": {
"node": ">= 6.0"
}
}
}
@@ -1,4 +1,5 @@
import { asyncOra } from '@electron-forge/async-ora';
import PluginBase from '@electron-forge/plugin-base';
import { IForgePluginInterface, ForgeConfig, IForgePlugin } from '@electron-forge/shared-types';
import { ChildProcess } from 'child_process';
import debug from 'debug';
@@ -70,7 +71,7 @@ export default class PluginInterface implements IForgePluginInterface {
let newStartFn;
const claimed = [];
for (const plugin of this.plugins) {
if (typeof plugin.startLogic === 'function') {
if (typeof plugin.startLogic === 'function' && plugin.startLogic !== PluginBase.prototype.startLogic) {
claimed.push(plugin.name);
newStartFn = plugin.startLogic;
}

0 comments on commit 9164ec5

Please sign in to comment.
You can’t perform that action at this time.