Skip to content
Permalink
Browse files

fix(generic): tabtab install script fails on non-*nix systems

ISSUES CLOSED: #314
  • Loading branch information
MarshallOfSound committed Sep 4, 2017
1 parent 461c7f1 commit fc3c03016926c7c30ea468125c8c75c023afa684
Showing with 1 addition and 1 deletion.
  1. +1 −1 tabtab-install.js
@@ -3,5 +3,5 @@ process.argv.push('--auto');
try {
require('tabtab/src/cli');
} catch (e) {
console.warning(`Failed to install tab completion: ${e}`);
console.warn(`Failed to install tab completion: ${e}`);
}

2 comments on commit fc3c030

@jfix

This comment has been minimized.

Copy link

jfix replied Sep 4, 2017

Thanks for the quick fix, but could it be that there's more to it than just the warning typo?

$ npm install -g electron-forge
npm WARN deprecated wrench@1.5.9: wrench.js is deprecated! You should check out fs-extra (https://github.com/jprichardson/node-fs-extra) for any operations you were using wrench for. Thanks for all the usage over the years.
npm WARN deprecated minimatch@0.3.0: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue
C:\Users\fix_j\AppData\Roaming\npm\electron-forge-vscode-win -> C:\Users\fix_j\AppData\Roaming\npm\node_modules\electron-forge\script\vscode.cmd
C:\Users\fix_j\AppData\Roaming\npm\electron-forge -> C:\Users\fix_j\AppData\Roaming\npm\node_modules\electron-forge\dist\electron-forge.js
C:\Users\fix_j\AppData\Roaming\npm\forge -> C:\Users\fix_j\AppData\Roaming\npm\node_modules\electron-forge\dist\electron-forge.js
C:\Users\fix_j\AppData\Roaming\npm\electron-forge-vscode-nix -> C:\Users\fix_j\AppData\Roaming\npm\node_modules\electron-forge\script\vscode.sh

> electron-forge@4.0.1 install C:\Users\fix_j\AppData\Roaming\npm\node_modules\electron-forge
> node tabtab-install.js

Failed to install tab completion: Error: ENOENT: no such file or directory, open 'C:\Users\fix_j\AppData\Roaming\npm\node_modules\electron-forge\node_modules\tabtab\scripts\C:\Users\fix_j\AppData\Local\Programs\Git\usr\bin\bash.sh'

It seems like the install process wants to execute node tabtab-install.js after all and can't find the script.

@MarshallOfSound

This comment has been minimized.

Copy link
Member Author

MarshallOfSound replied Sep 4, 2017

@jfix That is fine, you can ignore the warning, the install succeeded

Please sign in to comment.
You can’t perform that action at this time.