Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

application icon broken in ubuntu 18.04 alpha dash area #135

Closed
MichinariNukazawa opened this Issue Mar 14, 2018 · 8 comments

Comments

Projects
None yet
3 participants
@MichinariNukazawa
Copy link

MichinariNukazawa commented Mar 14, 2018

What version of electron-installer-debian are you using?
0.8.1

What version of node and npm are you using?
v6.12.0/3.5.2

What operating system are you using?
Ubuntu 18.04 alpha

Can you compile the example app successfully?
yes

What did you do? Please include the configuration you are using for electron-installer-debian.

{
	"name": "daisy-sequence",
	"src": "../release/release/daisy_sequence-linux-x64/",
	"dest": "../release/release/",
	"arch": "amd64",
	"icon": "image/icon.png",
	"categories": [
		"Utility"
	],
	"lintianOverrides": [
		"changelog-file-missing-in-native-package"
	]
}

What did you expect to happen?
The application icon is displayed correctly in the Dash area on the left side of the screen

What actually happened?
Application icon is not displayed correctly

** Other **
In Ubuntu 16.04 the application icon was displayed correctly.
In Ubuntu 18.04 application search (Alt + F2), icons are displayed correctly.
(To be honest, I think that this problem is a problem that Ubuntu changed its specifications)

screenshot
screenshot

icon file
icon

@fcastilloec

This comment has been minimized.

Copy link
Collaborator

fcastilloec commented Mar 14, 2018

Given that Ubuntu 18.04 is still under development, we really don't know what's going on.
This is very likely an Ubuntu bug rather than a bug on our side. We'll have to keep an eye on this. I'll appreciate it if you can keep testing with future releases and keeps us updated

@MichinariNukazawa

This comment has been minimized.

Copy link
Author

MichinariNukazawa commented Mar 15, 2018

If this problem is a Ubuntu bug, we should report a bug before it is released.
Although I can report it, I am not an English speaker, so I'm not sure I can communicate correctly.

@MichinariNukazawa

This comment has been minimized.

Copy link
Author

MichinariNukazawa commented Mar 19, 2018

Because I can not make it in time for release unless I keep doing anything like this, will I write a bug report for Ubuntu launchpad?

@malept

This comment has been minimized.

Copy link
Member

malept commented Mar 19, 2018

You should see if the bug exists in Ubuntu 17.10 as well. If not, file a bug at Ubuntu's issue tracker.

@fcastilloec

This comment has been minimized.

Copy link
Collaborator

fcastilloec commented May 12, 2018

I've been using Ubuntu 18.04 for 2 weeks now and I can't reproduce this in any way. I'm going to close this issue. @MichinariNukazawa if you still have problems , feel free to re-open the issue with more details, and maybe a log output

@MichinariNukazawa

This comment has been minimized.

Copy link
Author

MichinariNukazawa commented May 13, 2018

I reploduction now, in Ubuntu 18.04 release (clean installed release version).

Install log output:
sudo dpkg -i --debug=20 --log=log20.log lina-dicto-english_0.1.14_amd64.deb
log20.log

@fcastilloec

This comment has been minimized.

Copy link
Collaborator

fcastilloec commented May 13, 2018

I took a quick look at your repository and the problem is not with this package, it's that you never assigned an icon to the window you create in electron.
If you change index.js#L14 to look like the following:

win = new BrowserWindow({
  width: 800,
  height: 600,
  icon: 'image/icon.png'
})

And just do npm run build you will already see that your program has an icon when running on Ubuntu 18.04. With the old code, if you just did npm run build or electron . your app never had an icon, so even when packaging it, you still don't have an icon.

@MichinariNukazawa

This comment has been minimized.

Copy link
Author

MichinariNukazawa commented May 13, 2018

I solved my application problem.
Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.